Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 330603002: Make SpeechSynthesis gracefully handle ExecutionContext-less operation. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make SpeechSynthesis gracefully handle ExecutionContext-less operation. The SpeechSynthesis may lose its observed execution context and still be accessed by the platform. Check if present before accessing the context. R=haraken@chromium.org BUG=345061 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/modules/speech/SpeechSynthesis.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look. No test provided here, unable to construct one, but reliable repro ...
6 years, 6 months ago (2014-06-12 09:51:06 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-12 10:27:17 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-12 10:36:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/330603002/1
6 years, 6 months ago (2014-06-12 10:36:41 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 11:07:37 UTC) #5
Message was sent while issue was closed.
Change committed as 176018

Powered by Google App Engine
This is Rietveld 408576698