HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (media eng…

Source/core/html/HTMLMediaElement.cpp

Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 385f7ee088b0d2f72e17a66f06fe6ff430d477e0..69e802f33b73138ef138fecc19eb376db56c274f 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -1460,6 +1460,7 @@ void HTMLMediaElement::noneSupported()
 
 void HTMLMediaElement::mediaEngineError(PassRefPtrWillBeRawPtr<MediaError> err)
 {
+    ASSERT(m_readyState >= HAVE_METADATA);
     WTF_LOG(Media, "HTMLMediaElement::mediaEngineError(%d)", static_cast<int>(err->code()));
 
     // 1 - The user agent should cancel the fetching process.
@@ -1475,9 +1476,9 @@ void HTMLMediaElement::mediaEngineError(PassRefPtrWillBeRawPtr<MediaError> err)
 
     closeMediaSource();
 
-    // 4 - Set the element's networkState attribute to the NETWORK_EMPTY value and queue a
+    // 4 - Set the element's networkState attribute to the NETWORK_IDLE value and queue a
     // task to fire a simple event called emptied at the element.
-    m_networkState = NETWORK_EMPTY;
+    m_networkState = NETWORK_IDLE;
     scheduleEvent(EventTypeNames::emptied);

[philipj_slow, 2014/06/18 13:52:14]

If we are to match what the spec will probably come to say, it should be "Set
the element's networkState attribute to the NETWORK_IDLE value."

In other words, no emptied event here.

[Srirama, 2014/06/18 14:15:08]

Done.

 
     // 5 - Set the element's delaying-the-load-event flag to false. This stops delaying the load event.