LayoutTests/http/tests/media/video-load-metadata-decode-error.html - Issue 330593005: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (media eng…

Side by Side Diff: LayoutTests/http/tests/media/video-load-metadata-decode-error.html

Issue 330593005: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (media eng… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed emptied event Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi ('K') | « LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi ('k') | LayoutTests/http/tests/media/video-load-metadata-decode-error-expected.txt » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>throttled loading metadata</title>

	4 <script src=../../../media-resources/media-file.js></script>

	5 <script src=../../../media-resources/video-test.js></script>

	6 <script>

	7 function loadedmetadata(e)

	8 {

	9 logResult(true, "loaded metadata of media file");

	10 }

	11

	12 function error(e)

	13 {

	14 logResult(true, "failed to load media file");
	acolwell GONE FROM CHROMIUM 2014/06/18 23:46:27 nit: Just use consoleWrite() here and above since nit: Just use consoleWrite() here and above since a condition isn't actually being tested in either place. Srirama 2014/06/19 03:35:15 will do it. On 2014/06/18 23:46:27, acolwell wrote will do it. On 2014/06/18 23:46:27, acolwell wrote: Show quoted text > nit: Just use consoleWrite() here and above since a condition isn't actually > being tested in either place.
	15 testExpected("video.networkState", 1);
	acolwell GONE FROM CHROMIUM 2014/06/18 23:46:27 s/1/HTMLMediaElement.NETWORK_IDLE to make it clear s/1/HTMLMediaElement.NETWORK_IDLE to make it clearer what is expected. Srirama 2014/06/19 03:35:15 will do it. On 2014/06/18 23:46:27, acolwell wrote will do it. On 2014/06/18 23:46:27, acolwell wrote: Show quoted text > s/1/HTMLMediaElement.NETWORK_IDLE to make it clearer what is expected.
	16 endTest();

	17 }

	18

	19 function start()

	20 {

	21 findMediaElement();

	22

	23 waitForEvent('loadedmetadata', loadedmetadata);

	24 waitForEvent("error", error);

	25

	26 var movie = findMediaFile("video", "resources/test");

	27 var type = mimeTypeForExtension(movie.split('.').pop());

	28 video.src = "http://127.0.0.1:8000/media/video-load-metadata-decode- error.cgi?name=" + movie + "&type=" + type;
	acolwell GONE FROM CHROMIUM 2014/06/18 23:46:27 nit: Do you really need the scheme and host? Will nit: Do you really need the scheme and host? Will the following relative path work? "video-load-metadata-decode-error.cgi?name=" + movie + "&type=" + ty Srirama 2014/06/19 03:35:16 May not be required, will check and remove. On 201 May not be required, will check and remove. On 2014/06/18 23:46:27, acolwell wrote: Show quoted text > nit: Do you really need the scheme and host? Will the following relative path > work? > "video-load-metadata-decode-error.cgi?name=" + movie + "&type=" + ty
	29 video.load();

	30 video.play();
	acolwell GONE FROM CHROMIUM 2014/06/18 23:46:27 You should only need load() or play(). I don't thi You should only need load() or play(). I don't think you should need both. Ideally it would be nice if you could just use load(). Srirama 2014/06/19 03:35:16 I think there is a problem without play(). May be I think there is a problem without play(). May be metadata is missing or error is not coming. Will check and remove load(). On 2014/06/18 23:46:27, acolwell wrote: Show quoted text > You should only need load() or play(). I don't think you should need both. > Ideally it would be nice if you could just use load().
	31 }

	32 </script>

	33 </head>

	34 <body onload="start()">

	35 <video id="video"></video>

	36 <p>

	37 This test case simulates a decode error after loading meta data of a video.<br/> <br/>

	38 </p>

	39 </body>

	40 </html>

OLD	NEW