Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 330573003: Use raw strings for javac colorize regexes (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Use raw strings for javac colorize regexes Particularly the '\\' in fileline_prefix would need to be '\\\\' in a normal (non-raw) python string. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/gyp/javac.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
nyquist: *
6 years, 6 months ago (2014-06-11 22:45:01 UTC) #1
nyquist
lgtm
6 years, 6 months ago (2014-06-12 15:46:15 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-12 15:55:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/330573003/1
6 years, 6 months ago (2014-06-12 15:58:32 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 18:20:46 UTC) #5
Message was sent while issue was closed.
Change committed as 276748

Powered by Google App Engine
This is Rietveld 408576698