Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 330543008: [Telemetry] Have powermetrics summarize power usage rather than doing it by ourselves (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Have powermetrics summarize power usage rather than doing it by ourselves Tell `powermetrics` to print a summary instead of telling it to sample and summing ourselves. Aim is to try to get more accurate measurements. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276881

Patch Set 1 #

Patch Set 2 : Fix review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py View 1 5 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
lgtm
6 years, 6 months ago (2014-06-12 19:40:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/330543008/20001
6 years, 6 months ago (2014-06-12 19:42:39 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 01:40:17 UTC) #3
Message was sent while issue was closed.
Change committed as 276881

Powered by Google App Engine
This is Rietveld 408576698