Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 330543004: Only FontCache should know about system font substitution (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto
Modified:
6 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, jamesr, krit, blink-reviews-css, ed+blinkwatch_opera.com, jbroman, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, Stephen Chennney, rune+blink, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Only FontCache should know about system font substitution BUG=376377 TEST=no new test; just refactoring Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/css/LocalFontFaceSource.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Kunihiko Sakamoto
6 years, 6 months ago (2014-06-12 08:58:44 UTC) #1
Kunihiko Sakamoto
ping?
6 years, 6 months ago (2014-06-17 01:58:06 UTC) #2
eae
LGTM
6 years, 6 months ago (2014-06-17 01:59:41 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-17 01:59:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/330543004/1
6 years, 6 months ago (2014-06-17 02:00:41 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 02:09:33 UTC) #6
Message was sent while issue was closed.
Change committed as 176265

Powered by Google App Engine
This is Rietveld 408576698