Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 330513004: GetRepositoryPath now supports git alternates (Closed)

Created:
6 years, 6 months ago by David Yen
Modified:
6 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
/usr/local/google/home/dyen/base/nacl/native_client/toolchain_build/git_cache/chromium.googlesource.com-native_client-pnacl--llvm@master
Visibility:
Public.

Description

GetRepositoryPath now supports git alternates R=jvoung@chromium.org BUG=None TEST= trybots

Patch Set 1 #

Patch Set 2 : test upload #

Patch Set 3 : Echo error to stderr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M utils/GetRepositoryPath View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
David Yen
6 years, 6 months ago (2014-06-12 19:32:49 UTC) #1
jvoung (off chromium)
Hmm the base URL on rietveld is now pretty long. Any idea why? Otherwise: * ...
6 years, 6 months ago (2014-06-12 19:52:40 UTC) #2
David Yen
On 2014/06/12 19:52:40, jvoung wrote: > Hmm the base URL on rietveld is now pretty ...
6 years, 6 months ago (2014-06-12 21:19:02 UTC) #3
David Yen
On 2014/06/12 21:19:02, David Yen wrote: > On 2014/06/12 19:52:40, jvoung wrote: > > Hmm ...
6 years, 6 months ago (2014-06-12 23:01:50 UTC) #4
jvoung (off chromium)
On 2014/06/12 23:01:50, David Yen wrote: > On 2014/06/12 21:19:02, David Yen wrote: > > ...
6 years, 6 months ago (2014-06-12 23:07:25 UTC) #5
David Yen
6 years, 6 months ago (2014-06-26 21:53:57 UTC) #6
This CL has been made obsolete with this change:

https://codereview.chromium.org/355883002/

I am closing it now.

Powered by Google App Engine
This is Rietveld 408576698