Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 330513002: Disentangle updating the ScrollingCoordinator from RenderLayerCompositor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 18fd498f449bbd6c4ea1fea6390007f59ac465c1..812e7a74abd460ddbb9a9902fe6026e9ae487e67 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -2832,7 +2832,14 @@ void FrameView::updateLayoutAndStyleForPainting()
if (RenderView* view = renderView()) {
InspectorInstrumentation::willUpdateLayerTree(view->frame());
+
view->compositor()->updateIfNeededRecursive();
+
+ // FIXME: Is it really possible to be inCompositingMode and not have a ScrollingCoordinator?
ojan 2014/06/12 03:49:57 I tried removing the inCompositingMode check once
+ // FIXME: Is it really possible to have a RenderView and not have a Page?
ojan 2014/06/12 03:49:57 I don't think so. This code is littered with impos
ojan 2014/06/12 03:49:57 I don't think so. This code is littered with impos
+ if (view->compositor()->inCompositingMode() && m_frame->isMainFrame() && m_frame->page() && m_frame->page()->scrollingCoordinator())
+ m_frame->page()->scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
+
InspectorInstrumentation::didUpdateLayerTree(view->frame());
}
« no previous file with comments | « no previous file | Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698