Issue 3305004: Fix geolocation icon behaviour on navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3305004: Fix geolocation icon behaviour on navigation (Closed)

Created:
10 years, 3 months ago by allanwoj

Modified:
9 years, 6 months ago

Reviewers:
joth, jochen (gone - plz use gerrit)

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix geolocation icon behaviour on navigation Now clears the allowed/not allowed geolocation statemap at the beginning of a navigation in a similar way for cookies as done in this CL http://codereview.chromium.org/3194005 Before the icon would hang around after navigation until a tab contents update occurred. BUG=53339 TEST=Start up geolocation on a website then navigate away. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58364

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -1 line)			Patch
M	chrome/browser/geolocation/geolocation_settings_state.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_settings_state.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_specific_content_settings.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_specific_content_settings.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages