Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 330493002: Add UMA stat to track usage of Chrome for Linux accross different window managers (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add UMA stat to track usage of Chrome for Linux across different window managers. Knowing which window managers Chrome is most often used on will help in testing in new feature development. BUG=372580 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276593

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 4 chunks +70 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pkotwicz
Elliot, can you please take an initial looks before I send it off to isherman@
6 years, 6 months ago (2014-06-11 17:54:48 UTC) #1
Elliot Glaysher
I guess this lg, but I don't know anything about uma stats.
6 years, 6 months ago (2014-06-11 19:09:08 UTC) #2
pkotwicz
Isherman@ can you please take a look?
6 years, 6 months ago (2014-06-11 19:24:38 UTC) #3
Ilya Sherman
LGTM % a comment: https://codereview.chromium.org/330493002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/330493002/diff/1/tools/metrics/histograms/histograms.xml#newcode9349 tools/metrics/histograms/histograms.xml:9349: + <summary>The window manager used. ...
6 years, 6 months ago (2014-06-11 20:07:56 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-11 21:46:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/330493002/20001
6 years, 6 months ago (2014-06-11 21:48:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:04:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:06:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160434) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149843) ios_rel_device_ninja ...
6 years, 6 months ago (2014-06-11 23:06:14 UTC) #9
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-12 01:28:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/330493002/20001
6 years, 6 months ago (2014-06-12 01:32:20 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 09:12:33 UTC) #12
Message was sent while issue was closed.
Change committed as 276593

Powered by Google App Engine
This is Rietveld 408576698