Offline blacklisting for SuggestionsService.

chrome/browser/search/suggestions/blacklist_store_unittest.cc

Index: chrome/browser/search/suggestions/blacklist_store_unittest.cc
diff --git a/chrome/browser/search/suggestions/blacklist_store_unittest.cc b/chrome/browser/search/suggestions/blacklist_store_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a391b30df8216ccec08148e43ecee10dc46b36b8
--- /dev/null
+++ b/chrome/browser/search/suggestions/blacklist_store_unittest.cc
@@ -0,0 +1,162 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/search/suggestions/blacklist_store.h"
+
+#include <set>
+#include <string>
+
+#include "base/metrics/statistics_recorder.h"
+#include "chrome/browser/search/suggestions/proto/suggestions.pb.h"
+#include "chrome/test/base/testing_pref_service_syncable.h"
+#include "chrome/test/base/uma_histogram_helper.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace suggestions {
+
+namespace {
+
+const char kTestUrlA[] = "http://aaa.com/";
+const char kTestUrlB[] = "http://bbb.com/";
+const char kTestUrlC[] = "http://ccc.com/";
+const char kTestUrlD[] = "http://ddd.com/";
+
+const char* const kHistogramsToSnapshot[] = {"Suggestions.LocalBlacklistSize"};
+
+SuggestionsProfile CreateSuggestions(std::set<std::string> urls) {
+  SuggestionsProfile suggestions;
+  for (std::set<std::string>::iterator it = urls.begin(); it != urls.end();
+       ++it) {
+    ChromeSuggestion* suggestion = suggestions.add_suggestions();
+    suggestion->set_url(*it);
+  }
+  return suggestions;
+}
+
+void ValidateSuggestions(const SuggestionsProfile& expected,
+                         const SuggestionsProfile& actual) {
+  ASSERT_EQ(expected.suggestions_size(), actual.suggestions_size());
+  for (int i = 0; i < expected.suggestions_size(); ++i) {
+    EXPECT_EQ(expected.suggestions(i).url(), actual.suggestions(i).url());
+    EXPECT_EQ(expected.suggestions(i).title(), actual.suggestions(i).title());
+    EXPECT_EQ(expected.suggestions(i).favicon_url(),
+              actual.suggestions(i).favicon_url());
+    EXPECT_EQ(expected.suggestions(i).thumbnail(),
+              actual.suggestions(i).thumbnail());
+  }
+}
+
+}  // namespace
+
+TEST(BlacklistStoreTest, BasicInteractions) {
+  TestingPrefServiceSyncable prefs;
+  BlacklistStore::RegisterProfilePrefs(prefs.registry());
+  BlacklistStore blacklist_store(&prefs);
+
+  // Create suggestions with A, B and C. C and D will be added to the blacklist.
+  std::set<std::string> suggested_urls;
+  suggested_urls.insert(kTestUrlA);
+  suggested_urls.insert(kTestUrlB);
+  const SuggestionsProfile suggestions_filtered =
+      CreateSuggestions(suggested_urls);
+  suggested_urls.insert(kTestUrlC);
+  const SuggestionsProfile original_suggestions =
+      CreateSuggestions(suggested_urls);
+  SuggestionsProfile suggestions;
+
+  // Filter with an empty blacklist.
+  suggestions.CopyFrom(original_suggestions);
+  blacklist_store.FilterSuggestions(&suggestions);
+  ValidateSuggestions(original_suggestions, suggestions);
+
+  // Add C and D to the blacklist and filter.
+  suggestions.CopyFrom(original_suggestions);
+  EXPECT_TRUE(blacklist_store.BlacklistUrl(GURL(kTestUrlC)));
+  EXPECT_TRUE(blacklist_store.BlacklistUrl(GURL(kTestUrlD)));
+  blacklist_store.FilterSuggestions(&suggestions);
+  ValidateSuggestions(suggestions_filtered, suggestions);
+
+  // Remove C from the blacklist and filter.
+  suggestions.CopyFrom(original_suggestions);
+  EXPECT_TRUE(blacklist_store.RemoveUrl(GURL(kTestUrlC)));
+  blacklist_store.FilterSuggestions(&suggestions);
+  ValidateSuggestions(original_suggestions, suggestions);
+}
+
+TEST(BlacklistStoreTest, BlacklistTwiceSuceeds) {
+  TestingPrefServiceSyncable prefs;
+  BlacklistStore::RegisterProfilePrefs(prefs.registry());
+  BlacklistStore blacklist_store(&prefs);
+  EXPECT_TRUE(blacklist_store.BlacklistUrl(GURL(kTestUrlA)));
+  EXPECT_TRUE(blacklist_store.BlacklistUrl(GURL(kTestUrlA)));
+}
+
+TEST(BlacklistStoreTest, RemoveUnknownUrlSucceeds) {
+  TestingPrefServiceSyncable prefs;
+  BlacklistStore::RegisterProfilePrefs(prefs.registry());
+  BlacklistStore blacklist_store(&prefs);
+  EXPECT_TRUE(blacklist_store.RemoveUrl(GURL(kTestUrlA)));
+}
+
+TEST(BlacklistStoreTest, GetFirstUrlFromBlacklist) {
+  TestingPrefServiceSyncable prefs;
+  BlacklistStore::RegisterProfilePrefs(prefs.registry());
+  BlacklistStore blacklist_store(&prefs);
+
+  // Expect GetFirstUrlFromBlacklist fails when blacklist empty.
+  GURL retrieved;
+  EXPECT_FALSE(blacklist_store.GetFirstUrlFromBlacklist(&retrieved));
+
+  // Blacklist A and B.
+  EXPECT_TRUE(blacklist_store.BlacklistUrl(GURL(kTestUrlA)));
+  EXPECT_TRUE(blacklist_store.BlacklistUrl(GURL(kTestUrlB)));
+
+  // Expect to retrieve A or B.
+  EXPECT_TRUE(blacklist_store.GetFirstUrlFromBlacklist(&retrieved));
+  std::string retrieved_string = retrieved.spec();
+  EXPECT_TRUE(retrieved_string == std::string(kTestUrlA) ||
+              retrieved_string == std::string(kTestUrlB));
+}
+
+class BlacklistStoreLogTest : public testing::Test {

[Alexei Svitkine (slow), 2014/06/20 14:41:41]

If this is being used only for a single test, just put the two members at the
top of the test and remove this class.

[manzagop (departed), 2014/06/20 15:13:53]

Done.

+ public:
+  BlacklistStoreLogTest() {
+    base::StatisticsRecorder::Initialize();

[Alexei Svitkine (slow), 2014/06/20 14:41:41]

Is this still needed?

[manzagop (departed), 2014/06/20 15:13:53]

Done.

+  }
+  UMAHistogramHelper* histogram_helper() { return &histogram_helper_; }
+
+ private:
+  UMAHistogramHelper histogram_helper_;
+  content::TestBrowserThreadBundle bundle_;
+
+  DISALLOW_COPY_AND_ASSIGN(BlacklistStoreLogTest);
+};
+
+TEST_F(BlacklistStoreLogTest, LogsBlacklistSize) {
+  histogram_helper()->PrepareSnapshot(
+      kHistogramsToSnapshot, arraysize(kHistogramsToSnapshot));
+
+  // Create a first store - blacklist is empty at this point.
+  TestingPrefServiceSyncable prefs;
+  BlacklistStore::RegisterProfilePrefs(prefs.registry());
+  scoped_ptr<BlacklistStore> blacklist_store(new BlacklistStore(&prefs));
+  histogram_helper()->Fetch();
+  histogram_helper()->ExpectTotalCount("Suggestions.LocalBlacklistSize", 1);
+  histogram_helper()->ExpectUniqueSample("Suggestions.LocalBlacklistSize", 0,
+                                         1);
+
+  // Add some content to the blacklist.
+  EXPECT_TRUE(blacklist_store->BlacklistUrl(GURL(kTestUrlA)));
+  EXPECT_TRUE(blacklist_store->BlacklistUrl(GURL(kTestUrlB)));
+
+  // Create a new BlacklistStore and verify the counts.
+  blacklist_store.reset(new BlacklistStore(&prefs));
+  histogram_helper()->Fetch();
+  histogram_helper()->ExpectTotalCount("Suggestions.LocalBlacklistSize", 2);
+  histogram_helper()->ExpectBucketCount("Suggestions.LocalBlacklistSize", 0, 1);
+  histogram_helper()->ExpectBucketCount("Suggestions.LocalBlacklistSize", 2, 1);
+}
+
+}  // namespace suggestions