Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 330473003: Offline blacklisting for SuggestionsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address second round of comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2a77de3574b02d887843aa0b20f9697a06ce6347..6c2fe6c164f09f2947a4040562c676d37bb17c4d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -28869,7 +28869,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="Suggestions.FailedRequestErrorCode" enum="NetErrorCodes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>mathp@chromium.org</owner>
<summary>
The counts of network error codes encountered by SuggestionsService when an
attempt to fetch suggestions from the server fails.
@@ -28877,7 +28877,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="Suggestions.FetchResponseCode">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>mathp@chromium.org</owner>
<summary>
The counts of HTTP response codes encountered by SuggestionsService when
attempting to fetch suggestions from the server.
@@ -28885,15 +28885,23 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="Suggestions.FetchSuccessLatency" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>mathp@chromium.org</owner>
<summary>
The latency of a SuggestionsService fetch that results in a success
response.
</summary>
</histogram>
+<histogram name="Suggestions.LocalBlacklistSize" units="URLcount">
+ <owner>manzagop@chromium.org</owner>
+ <summary>
+ Number of URLs present in the Suggestions local blacklist when the
+ Suggestions service is created.
+ </summary>
+</histogram>
+
<histogram name="Suggestions.ResponseState" enum="SuggestionsResponseState">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>mathp@chromium.org</owner>
<summary>
The counts of response states (such as empty or invalid) encountered by
SuggestionsService when attempting to fetch suggestions from the server.
« chrome/browser/search/suggestions/suggestions_service.cc ('K') | « chrome/common/pref_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698