tools/metrics/histograms/histograms.xml - Issue 330473003: Offline blacklisting for SuggestionsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 330473003: Offline blacklisting for SuggestionsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address second round of comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 2a77de3574b02d887843aa0b20f9697a06ce6347..6c2fe6c164f09f2947a4040562c676d37bb17c4d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -28869,7 +28869,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>mathp@chromium.org</owner>

The counts of network error codes encountered by SuggestionsService when an

attempt to fetch suggestions from the server fails.

@@ -28877,7 +28877,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>mathp@chromium.org</owner>

The counts of HTTP response codes encountered by SuggestionsService when

attempting to fetch suggestions from the server.

@@ -28885,15 +28885,23 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>mathp@chromium.org</owner>

The latency of a SuggestionsService fetch that results in a success

response.

</summary>

</histogram>

+<histogram name="Suggestions.LocalBlacklistSize" units="URLcount">

+ <owner>manzagop@chromium.org</owner>

+ <summary>

+ Number of URLs present in the Suggestions local blacklist when the

+ Suggestions service is created.

+ </summary>

+</histogram>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

+ <owner>mathp@chromium.org</owner>

The counts of response states (such as empty or invalid) encountered by

SuggestionsService when attempting to fetch suggestions from the server.