Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 330453003: Disable surfaceless EGL on Android (Closed)

Created:
6 years, 6 months ago by oetuaho-nv
Modified:
6 years, 6 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Disable surfaceless EGL on Android There are outstanding bugs related to how Android code meant for WebView is interacting with surfaceless EGL. These cause crashing on startup and incorrect rendering on platforms that support surfaceless EGL. Work around the issues by disabling surfaceless EGL on Android to unblock work before a more complete solution can be developed. BUG=382349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276713

Patch Set 1 #

Patch Set 2 : Add bug URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/gl/gl_surface_egl.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oetuaho-nv
https://codereview.chromium.org/320283002/ did not cut it, so I'll leave the proper fix to the WebView people. ...
6 years, 6 months ago (2014-06-11 16:14:04 UTC) #1
no sievers
lgtm. Can you reference bug 382349 in the comment/TODO?
6 years, 6 months ago (2014-06-11 17:22:27 UTC) #2
Ken Russell (switch to Gerrit)
LGTM with sievers' comment addressed.
6 years, 6 months ago (2014-06-11 18:05:07 UTC) #3
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 6 months ago (2014-06-12 07:47:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/330453003/20001
6 years, 6 months ago (2014-06-12 07:54:21 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:47:59 UTC) #6
Message was sent while issue was closed.
Change committed as 276713

Powered by Google App Engine
This is Rietveld 408576698