Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5854)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 330443004: Bug fix: Translate: leak of a ComboboxModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sky's review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.h
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h
index 94a561aacdcd16f83fad4a4bf7bf0013e9ce597e..f35bd3e61fac806608f425b1fb3e6db429bd3344 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.h
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h
@@ -29,6 +29,10 @@ class Link;
class View;
}
+namespace ui {
+class SimpleComboboxModel;
+}
+
class TranslateBubbleView : public views::BubbleDelegateView,
public views::ButtonListener,
public views::ComboboxListener,
@@ -169,6 +173,7 @@ class TranslateBubbleView : public views::BubbleDelegateView,
views::View* error_view_;
views::View* advanced_view_;
+ scoped_ptr<ui::SimpleComboboxModel> denial_combobox_model_;
scoped_ptr<LanguageComboboxModel> source_language_combobox_model_;
scoped_ptr<LanguageComboboxModel> target_language_combobox_model_;

Powered by Google App Engine
This is Rietveld 408576698