Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/ui/translate/translate_denial_combobox_model.cc

Issue 330443004: Bug fix: Translate: leak of a ComboboxModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the order of the member variables Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_denial_combobox_model.cc
diff --git a/chrome/browser/ui/translate/translate_denial_combobox_model.cc b/chrome/browser/ui/translate/translate_denial_combobox_model.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8c072ca5935940b1e4973b99e9c3cf194d7bcb98
--- /dev/null
+++ b/chrome/browser/ui/translate/translate_denial_combobox_model.cc
@@ -0,0 +1,38 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/translate/translate_denial_combobox_model.h"
+
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+TranslateDenialComboboxModel::TranslateDenialComboboxModel(
+ const base::string16& original_language_name) {
+ items_.push_back(l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_DENY));
+ items_.push_back(base::string16());
+ items_.push_back(l10n_util::GetStringFUTF16(
+ IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_LANG,
+ original_language_name));
+ items_.push_back(base::string16());
+ items_.push_back(l10n_util::GetStringUTF16(
+ IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_SITE));
+}
+
+TranslateDenialComboboxModel::~TranslateDenialComboboxModel() {}
+
+int TranslateDenialComboboxModel::GetItemCount() const {
+ return items_.size();
+}
+
+base::string16 TranslateDenialComboboxModel::GetItemAt(int index) {
+ return items_[index];
+}
+
+bool TranslateDenialComboboxModel::IsItemSeparatorAt(int index) {
+ return items_[index].empty();
+}
+
+int TranslateDenialComboboxModel::GetDefaultIndex() const {
+ return 0;
+}

Powered by Google App Engine
This is Rietveld 408576698