Bug fix: Translate: leak of a ComboboxModel

chrome/browser/ui/translate/translate_denial_combobox_model.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_DENIAL_COMBOBOX_MODEL_H_
+#define CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_DENIAL_COMBOBOX_MODEL_H_
+
+#include <vector>
+
+#include "base/basictypes.h"
+#include "ui/base/models/combobox_model.h"
+
+class TranslateDenialComboboxModel : public ui::ComboboxModel {

[sky, 2014/06/17 16:30:38]

How about a SimpleComboboxModel in ui/base/models that takes a
std::vector<base::string16> ?

[hajimehoshi, 2014/06/18 08:33:37]

Done.

+ public:
+  enum {

[sky, 2014/06/17 16:30:38]

Generally we use C++ style for enums.

[hajimehoshi, 2014/06/18 08:33:37]

Done.

+    INDEX_NOPE = 0,
+    INDEX_NEVER_TRANSLATE_LANGUAGE = 2,
+    INDEX_NEVER_TRANSLATE_SITE = 4,
+  };
+
+  explicit TranslateDenialComboboxModel(
+      const base::string16& original_language_name);
+  virtual ~TranslateDenialComboboxModel();
+
+ private:
+  // Overridden from ui::ComboboxModel:
+  virtual int GetItemCount() const OVERRIDE;
+  virtual base::string16 GetItemAt(int index);
+  virtual bool IsItemSeparatorAt(int index);
+  virtual int GetDefaultIndex() const;
+
+  std::vector<base::string16> items_;
+
+  DISALLOW_COPY_AND_ASSIGN(TranslateDenialComboboxModel);
+};
+
+#endif  // CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_DENIAL_COMBOBOX_MODEL_H_