Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 330433003: Suppress libpoppler and its dependent liblcms in TSAN. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Suppress libpoppler and its dependent liblcms in TSAN. This will let us eventually turn PDF back on in DM. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3b94b78b771e06b2294425103cacf37996f6a1ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/tsan.supp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
mtklein
6 years, 6 months ago (2014-06-11 20:54:12 UTC) #1
hal.canary
lgtm
6 years, 6 months ago (2014-06-11 20:54:45 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 6 months ago (2014-06-11 20:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/330433003/1
6 years, 6 months ago (2014-06-11 20:56:00 UTC) #4
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 6 months ago (2014-06-11 21:14:27 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-11 21:14:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/330433003/1
6 years, 6 months ago (2014-06-11 21:14:34 UTC) #7
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 6 months ago (2014-06-11 21:43:01 UTC) #8
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-11 21:43:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/330433003/1
6 years, 6 months ago (2014-06-11 21:43:07 UTC) #10
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 6 months ago (2014-06-11 23:29:55 UTC) #11
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-11 23:29:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/330433003/1
6 years, 6 months ago (2014-06-11 23:30:00 UTC) #13
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 6 months ago (2014-06-12 00:19:02 UTC) #14
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-12 00:19:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/330433003/1
6 years, 6 months ago (2014-06-12 00:19:12 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 00:22:19 UTC) #17
Message was sent while issue was closed. 
Change committed as 3b94b78b771e06b2294425103cacf37996f6a1ca

Powered by Google App Engine
This is Rietveld 408576698