Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 330433002: Move prepopulated_engines to components/search_engines (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
CC:
chromium-reviews, James Su, asvitkine+watch_chromium.org, blundell
Visibility:
Public.

Description

Move prepopulated_engines to components/search_engines Move search_engine_type.h from chrome/browser/search_engines to components/search_engines Move prepopulated_engines* to components/search_engines TBR=asvitkine@chromium.org for the comment fix in tools/metrics/histograms/histograms.xml BUG=371535 TEST=git cl try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276533

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1582 lines) Patch
M .gitignore View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/search_engines/prepopulated_engines.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/search_engines/prepopulated_engines.json View 1 chunk +0 lines, -1389 lines 0 comments Download
D chrome/browser/search_engines/prepopulated_engines_schema.json View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/search_engines/search_engine_type.h View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M components/search_engines.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/search_engines/prepopulated_engines.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/search_engines/prepopulated_engines.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/search_engines/prepopulated_engines_schema.json View 1 chunk +1 line, -1 line 0 comments Download
A + components/search_engines/search_engine_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
hashimoto
Peter, could you review this change?
6 years, 6 months ago (2014-06-11 09:48:47 UTC) #1
Peter Kasting
LGTM
6 years, 6 months ago (2014-06-11 18:45:44 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 00:07:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/330433002/60001
6 years, 6 months ago (2014-06-12 00:09:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:32:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:34:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21986)
6 years, 6 months ago (2014-06-12 00:34:28 UTC) #7
hashimoto
TBRing asvitkine@chromium.org for the comment fix in tools/metrics/histograms/histograms.xml
6 years, 6 months ago (2014-06-12 00:49:22 UTC) #8
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 00:49:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/330433002/60001
6 years, 6 months ago (2014-06-12 00:50:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:55:46 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 01:02:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21998)
6 years, 6 months ago (2014-06-12 01:02:59 UTC) #13
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 01:37:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/330433002/60001
6 years, 6 months ago (2014-06-12 01:39:29 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 04:16:26 UTC) #16
Message was sent while issue was closed. 
Change committed as 276533

Powered by Google App Engine
This is Rietveld 408576698