Issue 330413002: Add GN support for midl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330413002: Add GN support for midl. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add GN support for midl. Implement iaccessible and isimpledom R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277855

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -3 lines)			Patch
A	build/toolchain/win/midl.gni	View	1 chunk	+94 lines, -0 lines	0 comments	Download
M	build/toolchain/win/setup_toolchain.py	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	content/browser/BUILD.gn	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	third_party/iaccessible2/BUILD.gn	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	third_party/isimpledom/BUILD.gn	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/330413002/diff/1/build/toolchain/win/setup_toolchain.py File build/toolchain/win/setup_toolchain.py (right): https://codereview.chromium.org/330413002/diff/1/build/toolchain/win/setup_toolchain.py#newcode27 build/toolchain/win/setup_toolchain.py:27: 'include', # Needed by midl compiler. ah, you ...

6 years, 6 months ago (2014-06-17 20:32:40 UTC) #2

brettw

6 years, 6 months ago (2014-06-17 20:33:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r277855 (presubmit successful).

Expand Messages | Collapse Messages