Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 330383004: Oilpan: Introduce TempRangeScope to avoid needless Range attaches on Document. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index 4315ab30238de60418445f05796eaf54c5012be0..881720bdc75c7e9438846cbf4103b473b8708106 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -329,6 +329,7 @@ void FrameSelection::nodeWillBeRemoved(Node& node)
void FrameSelection::respondToNodeModification(Node& node, bool baseRemoved, bool extentRemoved, bool startRemoved, bool endRemoved)
{
ASSERT(node.document().isActive());
+ TemporaryRangeScope scope;
yosin_UTC9 2014/06/25 01:22:20 It seems tempoary new Range object is created by |
Mads Ager (chromium) 2014/06/25 11:41:42 It seems that all the comparison logic is all hidd
bool clearRenderTreeSelection = false;
bool clearDOMTreeSelection = false;

Powered by Google App Engine
This is Rietveld 408576698