Remove deprecated extension notifications from APIs

chrome/browser/extensions/api/file_system/file_system_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/saved_files_service.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
+#include "base/scoped_observer.h"
 #include "build/build_config.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
-#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/file_system/file_system_api.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_paths.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_service.h"
 #include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/extension_registry.h"
+#include "extensions/browser/extension_registry_observer.h"
 
 namespace extensions {
 
 namespace {
 
-class AppInstallObserver : public content::NotificationObserver {
+class AppLoadObserver : public ExtensionRegistryObserver {
  public:
-  AppInstallObserver(
-      base::Callback<void(const Extension*)> callback)
-      : callback_(callback) {
-    registrar_.Add(this,
-                   chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
-                   content::NotificationService::AllSources());
+  AppLoadObserver(Profile* profile,

[Devlin, 2014/06/17 16:28:31]

nit: This could actually just be a BrowserContext.

[limasdf, 2014/06/17 18:25:43]

Done.

+                  base::Callback<void(const Extension*)> callback)
+      : callback_(callback), extension_registry_observer_(this) {
+    extension_registry_observer_.Add(ExtensionRegistry::Get(profile));
   }
 
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) OVERRIDE {
-    EXPECT_EQ(chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED, type);
-    callback_.Run(content::Details<const Extension>(details).ptr());
+  virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
+                         const Extension* extension) OVERRIDE {

[Devlin, 2014/06/17 16:28:31]

nit: indentation is off

[limasdf, 2014/06/17 18:25:43]

Done.

+    callback_.Run(extension);
   }
 
  private:
-  content::NotificationRegistrar registrar_;
   base::Callback<void(const Extension*)> callback_;
-  DISALLOW_COPY_AND_ASSIGN(AppInstallObserver);
+  ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
+      extension_registry_observer_;
+  DISALLOW_COPY_AND_ASSIGN(AppLoadObserver);
 };
 
 void SetLastChooseEntryDirectory(const base::FilePath& choose_entry_directory,
                                  ExtensionPrefs* prefs,
                                  const Extension* extension) {
   file_system_api::SetLastChooseEntryDirectory(
       prefs, extension->id(), choose_entry_directory);
 }
 
 void AddSavedEntry(const base::FilePath& path_to_save,
@@ skipping 137 matching lines @@
   CheckStoredDirectoryMatches(test_file);
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest,
                        FileSystemApiOpenExistingFileUsingPreviousPathTest) {
   base::FilePath test_file = TempFilePath("open_existing.txt", true);
   ASSERT_FALSE(test_file.empty());
   FileSystemChooseEntryFunction::
       SkipPickerAndSelectSuggestedPathForTest();
   {
-    AppInstallObserver observer(
-        base::Bind(SetLastChooseEntryDirectory,
-                   test_file.DirName(),
-                   ExtensionPrefs::Get(profile())));
+    AppLoadObserver observer(profile(),

[limasdf, 2014/06/17 18:25:43]

I'm actually like to pass something like a browser_context(). but there's no :/

[Devlin, 2014/06/18 16:04:34]

Yeah, that's kind of annoying.  What we could (and probably should) do in a
followup patch is to add a "browser_context()" method to ExtensionBrowserTest
which returns the profile as a browser context.  But it's not too pressing (and
don't worry about it here).

[limasdf, 2014/06/19 01:48:42]

one day I'll do it!

+                             base::Bind(SetLastChooseEntryDirectory,
+                                        test_file.DirName(),
+                                        ExtensionPrefs::Get(profile())));
     ASSERT_TRUE(RunPlatformAppTest("api_test/file_system/open_existing"))
         << message_;
   }
   CheckStoredDirectoryMatches(test_file);
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest,
     FileSystemApiOpenExistingFilePreviousPathDoesNotExistTest) {
   base::FilePath test_file = TempFilePath("open_existing.txt", true);
   ASSERT_FALSE(test_file.empty());
   ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(
       chrome::DIR_USER_DOCUMENTS, test_file.DirName(), false, false));
   FileSystemChooseEntryFunction::
       SkipPickerAndSelectSuggestedPathForTest();
   {
-    AppInstallObserver observer(base::Bind(
-        SetLastChooseEntryDirectory,
-        test_file.DirName().Append(
-            base::FilePath::FromUTF8Unsafe("fake_directory_does_not_exist")),
-        ExtensionPrefs::Get(profile())));
+    AppLoadObserver observer(
+        profile(),
+        base::Bind(SetLastChooseEntryDirectory,
+                   test_file.DirName().Append(base::FilePath::FromUTF8Unsafe(
+                       "fake_directory_does_not_exist")),
+                   ExtensionPrefs::Get(profile())));
     ASSERT_TRUE(RunPlatformAppTest("api_test/file_system/open_existing"))
         << message_;
   }
   CheckStoredDirectoryMatches(test_file);
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest,
                        FileSystemApiOpenExistingFileDefaultPathTest) {
   base::FilePath test_file = TempFilePath("open_existing.txt", true);
   ASSERT_FALSE(test_file.empty());
@@ skipping 367 matching lines @@
   EXPECT_EQ(test_directory, file_entries[0].path);
   EXPECT_EQ(1, file_entries[0].sequence_number);
   EXPECT_TRUE(file_entries[0].is_directory);
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiRestoreEntry) {
   base::FilePath test_file = TempFilePath("writable.txt", true);
   ASSERT_FALSE(test_file.empty());
   FileSystemChooseEntryFunction::SkipPickerAndAlwaysSelectPathForTest(
       &test_file);
-  AppInstallObserver observer(
-      base::Bind(AddSavedEntry,
-                 test_file,
-                 false,
-                 apps::SavedFilesService::Get(profile())));
+  AppLoadObserver observer(profile(),
+                           base::Bind(AddSavedEntry,
+                                      test_file,
+                                      false,
+                                      apps::SavedFilesService::Get(profile())));
   ASSERT_TRUE(RunPlatformAppTest("api_test/file_system/restore_entry"))
       << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiRestoreDirectoryEntry) {
   base::FilePath test_file = TempFilePath("writable.txt", true);
   ASSERT_FALSE(test_file.empty());
   base::FilePath test_directory = test_file.DirName();
   FileSystemChooseEntryFunction::SkipPickerAndAlwaysSelectPathForTest(
       &test_file);
-  AppInstallObserver observer(
-      base::Bind(AddSavedEntry,
-                 test_directory,
-                 true,
-                 apps::SavedFilesService::Get(profile())));
+  AppLoadObserver observer(profile(),
+                           base::Bind(AddSavedEntry,
+                                      test_directory,
+                                      true,
+                                      apps::SavedFilesService::Get(profile())));
   ASSERT_TRUE(RunPlatformAppTest("api_test/file_system/restore_directory"))
       << message_;
 }
 
 }  // namespace extensions