Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 330343002: Introduce ChromeBookmarkClientFactory (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
Reviewers:
sdefresne, blundell
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, tfarina, haitaol+watch_chromium.org, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, sdefresne
Project:
chromium
Visibility:
Public.

Description

Introduce ChromeBookmarkClientFactory Fix BookmarkModelFactory to really build a BookmarkModel object and introduce another factory ChromeBookmarkClientFactory to build the ChromeBookmarkClient and manage the correct dependency between the two objects. Change BookmarkModelFactory::GetChromeBookmarkClientForProfile and clients to instead use ChromeBookmarkClientFactory::GetForProfile. BUG=364865 TBR=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -223 lines) Patch
M chrome/browser/bookmarks/DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 4 chunks +22 lines, -25 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.h View 4 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 5 chunks +27 lines, -18 lines 0 comments Download
A chrome/browser/bookmarks/chrome_bookmark_client_factory.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/bookmarks/chrome_bookmark_client_factory.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 3 chunks +28 lines, -22 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 9 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 4 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 29 chunks +52 lines, -50 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M components/bookmarks.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M components/bookmarks/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/policy/policy_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
Sylvain, I'm currently blocked by https://codereview.chromium.org/306293006 which isn't applying cleanly. This CL is a rebase ...
6 years, 6 months ago (2014-06-13 17:05:35 UTC) #1
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-06-13 17:05:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/330343002/1
6 years, 6 months ago (2014-06-13 17:06:35 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 21:51:23 UTC) #4
commit-bot: I haz the power
Change committed as 277138
6 years, 6 months ago (2014-06-14 00:11:37 UTC) #5
sdefresne
6 years, 6 months ago (2014-06-16 08:14:41 UTC) #6
Message was sent while issue was closed.
LGTM

Thank you for re-landing.

Powered by Google App Engine
This is Rietveld 408576698