Land Recent QUIC Changes.

net/quic/quic_protocol.h

Index: net/quic/quic_protocol.h
diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h
index 23bdd3e16e5cb005088d241f24bf9e309d53dcc1..eed756b3800a2525ffb948e6bf51007d556a1c37 100644
--- a/net/quic/quic_protocol.h
+++ b/net/quic/quic_protocol.h
@@ -158,7 +158,13 @@ enum IsHandshake {
 // Indicates FEC protection level for data being written.
 enum FecProtection {
   MUST_FEC_PROTECT,  // Callee must FEC protect this data.
-  MAY_FEC_PROTECT  // Callee does not have to but may FEC protect this data.
+  MAY_FEC_PROTECT    // Callee does not have to but may FEC protect this data.
+};
+
+// Indicates FEC policy

[Jana, 2014/06/16 21:28:12]

Per Wan-Teh's comment, I suggest a couple of things to help disambiguate the
meaning of these enums. (i) Expand this comment to say "Indicates FEC policy to
be used for this stream."  (ii) Change enum to be StreamFecPolicy and the values
to be FEC_PROTECT_STREAM_ALWAYS and  FEC_PROTECT_STREAM_OPTIONAL to clarify that
these policies are applied to a stream. Does that sound good? There are some
redundancies here, but I don't mind the extra clarification.

[wtc, 2014/06/16 22:05:53]

Yes, that sounds good.

[ramant (doing other things), 2014/06/16 23:46:52]

Will make this change in the next CL.

+enum FecPolicy {
+  FEC_PROTECT_ALWAYS,   // All data in the stream should be FEC protected.
+  FEC_PROTECT_OPTIONAL  // Data in the stream does not need FEC protection.
 };
 
 enum QuicFrameType {