Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 330333006: Land Recent QUIC Changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix linus_tsan error - reverted the change to ConnectionMigrationClientPortChanged unitttest Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 67d4d63f5bd96b6cb21dee417ad9d63205381071..41c3c27946aed4e2738d4251f379cabcbbe77acf 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -24,15 +24,16 @@
using base::StringPiece;
using net::EpollServer;
-using net::test::MockSession;
using net::test::ConstructEncryptedPacket;
+using net::test::MockSession;
+using net::test::ValueRestore;
using net::tools::test::MockConnection;
using std::make_pair;
-using testing::_;
using testing::DoAll;
-using testing::Invoke;
using testing::InSequence;
+using testing::Invoke;
using testing::WithoutArgs;
+using testing::_;
namespace net {
namespace tools {
@@ -47,8 +48,7 @@ class TestDispatcher : public QuicDispatcher {
: QuicDispatcher(config,
crypto_config,
QuicSupportedVersions(),
- eps,
- kInitialFlowControlWindowForTest) {
+ eps) {
}
MOCK_METHOD3(CreateQuicSession, QuicSession*(
@@ -283,12 +283,11 @@ TEST(QuicDispatcherFlowControlTest, NoNewVersion17ConnectionsIfFlagDisabled) {
kTestVersions.push_back(kTestQuicVersions[i]);
}
- QuicDispatcher dispatcher(config, server_config, kTestVersions, &eps,
- kInitialFlowControlWindowForTest);
+ QuicDispatcher dispatcher(config, server_config, kTestVersions, &eps);
dispatcher.Initialize(0);
// When flag is enabled, new connections should support QUIC_VERSION_17.
- FLAGS_enable_quic_stream_flow_control_2 = true;
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_stream_flow_control_2, true);
scoped_ptr<QuicConnection> connection_1(
QuicDispatcherPeer::CreateQuicConnection(&dispatcher, kCID, client,
server));
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698