Land Recent QUIC Changes.

net/quic/quic_protocol.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_PROTOCOL_H_
 #define NET_QUIC_QUIC_PROTOCOL_H_
 
 #include <stddef.h>
 #include <limits>
 #include <map>
@@ skipping 140 matching lines @@
 };
 
 enum IsHandshake {
   NOT_HANDSHAKE,
   IS_HANDSHAKE
 };
 
 // Indicates FEC protection level for data being written.
 enum FecProtection {
   MUST_FEC_PROTECT,  // Callee must FEC protect this data.
-  MAY_FEC_PROTECT  // Callee does not have to but may FEC protect this data.
+  MAY_FEC_PROTECT    // Callee does not have to but may FEC protect this data.
+};
+
+// Indicates FEC policy
+enum FecPolicy {
+  PROTECT_ALWAYS,   // All data in the stream should be FEC protected.
+  PROTECT_OPTIONAL  // Data in the stream does not need FEC protection.

[wtc, 2014/06/16 19:35:56]

I suggest adding the "FEC_" prefix to these two enumerators because they can be
used without the FecPolicy:: prefix.

Also, I find MUST_FEC_PROTECT vs. MAY_FEC_PROTECT to be very similar to
PROTECT_ALWAYS vs. PROTECT_OPTIONAL. So I'm afraid that I would not be able to
know when to use FecProtection or FecPolicy.

[ramant (doing other things), 2014/06/16 21:13:52]

Added FEC_ prefix.

Done.

 };
 
 enum QuicFrameType {
   // Regular frame types. The values set here cannot change without the
   // introduction of a new QUIC version.
   PADDING_FRAME = 0,
   RST_STREAM_FRAME = 1,
   CONNECTION_CLOSE_FRAME = 2,
   GOAWAY_FRAME = 3,
   WINDOW_UPDATE_FRAME = 4,
@@ skipping 883 matching lines @@
   // Stores the sequence numbers of all transmissions of this packet.
   // Can never be null.
   SequenceNumberSet* all_transmissions;
   // In flight packets have not been abandoned or lost.
   bool in_flight;
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_PROTOCOL_H_