Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java

Issue 330333003: [Android] Battery Status API: some tweaks to the BatteryStatusManager.java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mounir's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java b/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
index c7fb259088924298c307730cfe08c1966eae4892..e0846cbee316989b58ce1f7e8a9d8db3673e2ceb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
@@ -9,6 +9,7 @@ import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.os.BatteryManager;
+import android.os.Build;
import android.util.Log;
import com.google.common.annotations.VisibleForTesting;
@@ -88,24 +89,44 @@ class BatteryStatusManager {
return;
}
+ boolean present = ignoreBatteryPresentState() ?
+ true : intent.getBooleanExtra(BatteryManager.EXTRA_PRESENT, false);
+
+ if (!present) {
+ // No battery, return default values.
+ gotBatteryStatus(true, 0, Double.POSITIVE_INFINITY, 1);
+ return;
+ }
+
int current = intent.getIntExtra(BatteryManager.EXTRA_LEVEL, -1);
int max = intent.getIntExtra(BatteryManager.EXTRA_SCALE, -1);
double level = (double)current / (double)max;
+ if (level < 0 || level > 1) {
+ // Sanity check, assume default value in this case.
+ level = 1.0;
+ }
int status = intent.getIntExtra(BatteryManager.EXTRA_STATUS, -1);
- // by default assume a battery is present
- boolean present = intent.getBooleanExtra(BatteryManager.EXTRA_PRESENT, true);
- boolean charging = (present && status == BatteryManager.BATTERY_STATUS_DISCHARGING)
- ? false : true;
-
- //TODO(timvolodine) : add proper projection for chargingTime, dischargingTime.
- double chargingTime = (!present || status == BatteryManager.BATTERY_STATUS_FULL)
- ? 0 : Double.POSITIVE_INFINITY;
+ boolean charging = !(status == BatteryManager.BATTERY_STATUS_DISCHARGING);
+
+ // TODO(timvolodine) : add proper projection for chargingTime, dischargingTime.
+ double chargingTime = (status == BatteryManager.BATTERY_STATUS_FULL) ?
+ 0 : Double.POSITIVE_INFINITY;
double dischargingTime = Double.POSITIVE_INFINITY;
gotBatteryStatus(charging, chargingTime, dischargingTime, level);
}
+ /**
+ * Returns whether the BatteryStatusManager should ignore the battery present state.
+ * It is required for some devices that incorrectly set the EXTRA_PRESENT property.
+ */
+ protected boolean ignoreBatteryPresentState() {
+ // BatteryManager.EXTRA_PRESENT appears to be unreliable on Galaxy Nexus,
+ // Android 4.2.1, it always reports false. See crbug.com/384348.
+ return Build.MODEL.equals("Galaxy Nexus");
+ }
+
protected void gotBatteryStatus(boolean charging, double chargingTime,
double dischargingTime, double level) {
synchronized (mNativePtrLock) {
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698