Source/bindings/scripts/v8_attributes.py - Issue 330293002: Removing unnecessary PerWorldBindings for DOM API calls that are monitored by Activity Logger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 330293002: Removing unnecessary PerWorldBindings for DOM API calls that are monitored by Activity Logger. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 46ea36fda60198eb405e250046fb420934db9bf8..da557ae282745e5bd04852d1a4cf498316b13750 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -94,6 +94,7 @@ def generate_attribute(interface, attribute):

'activity_logging_world_list_for_getter': v8_utilities.activity_logging_world_list(attribute, 'Getter'), # [ActivityLogging]

'activity_logging_world_list_for_setter': v8_utilities.activity_logging_world_list(attribute, 'Setter'), # [ActivityLogging]

'activity_logging_include_old_value_for_setter': 'LogPreviousValue' in extended_attributes, # [ActivityLogging]

+ 'activity_logging_world_check': v8_utilities.activity_logging_world_check(attribute), # [ActivityLogging]

'cached_attribute_validation_method': extended_attributes.get('CachedAttribute'),

'conditional_string': v8_utilities.conditional_string(attribute),

'constructor_type': idl_type.constructor_type_name

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »