New RietveldPollerWithCache is working stable. Removed old RietveldPoller and the flag to choose be…

New RietveldPollerWithCache is working stable. Removed old RietveldPoller and the flag to choose between the two.

BUG=160709
R=sergeyberezin@chromium.org, phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=277420

[Sergiy Byelozyorov, 2014-06-13 18:10:30]

Test locally on tryserver.chromium and tryserver.webrtc. Works as intended.

[Sergiy Byelozyorov, 2014-06-14 02:49:36]

PTAL

[Paweł Hajdan Jr., 2014-06-16 10:37:30]

LGTM with a comment

https://codereview.chromium.org/330283006/diff/1/masters/master.tryserver.bli...
File masters/master.tryserver.blink/master.cfg (left):

https://codereview.chromium.org/330283006/diff/1/masters/master.tryserver.bli...
masters/master.tryserver.blink/master.cfg:105:
cachepath=os.path.join(os.getcwd(), 'try_job_rietveld.json'),
Do we still need cachepath with the new poller?

[Sergiy Byelozyorov, 2014-06-16 14:05:01]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2014-06-16 14:05:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergiyb@chromium.org/330283006/20001

[commit-bot: I haz the power, 2014-06-16 14:06:57]

Change committed as 277420

[Sergey Berezin, 2014-06-17 17:22:59]

LGTM

[ghost stip (do not use), 2014-06-18 00:51:31]

this change broke internal masters. note that CQ only tests the public side of
the code

[Sergiy Byelozyorov, 2014-07-14 16:46:20]

The CQ bit was checked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-07-14 16:46:21]

The CQ bit was unchecked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-07-14 16:46:21]

The CQ bit was checked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-07-14 16:46:24]

The CQ bit was unchecked by sergiyb@chromium.org