Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 330283004: User Manager UI fixes (Closed)

Created:
6 years, 6 months ago by noms (inactive)
Modified:
6 years, 6 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

User Manager UI fixes - use high dpi resources - add a logo to the tray - css fixes: increase the tray height, hover/focused states of pods, increase the profile name box - ensure non-focused pods are faded out - update/make equal the padding between pod rows and columns - change the style of the action box drop down arrow See crbug for mocks. Screenshots: https://drive.google.com/file/d/0B1B1Up4p2NRMUDFqWmgtSGVlbmM/edit?usp=sharing BUG=380273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277815

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : fix rtl #

Patch Set 4 : fix user pod spacing on desktop #

Total comments: 2

Patch Set 5 : nikita nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -28 lines) Patch
M chrome/browser/resources/login/user_pod_row.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/login/user_pod_row.js View 1 2 3 4 8 chunks +45 lines, -10 lines 0 comments Download
M chrome/browser/resources/user_manager/control_bar.css View 1 2 4 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/resources/user_manager/control_bar.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager.css View 1 3 chunks +51 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noms (inactive)
6 years, 6 months ago (2014-06-13 18:06:15 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/330283004/diff/1/chrome/browser/resources/login/user_pod_row.css File chrome/browser/resources/login/user_pod_row.css (left): https://codereview.chromium.org/330283004/diff/1/chrome/browser/resources/login/user_pod_row.css#oldcode255 chrome/browser/resources/login/user_pod_row.css:255: border: 0 !important; I thought that this change ...
6 years, 6 months ago (2014-06-16 15:28:10 UTC) #2
noms (inactive)
I've made a few changes. Please take another look. :) https://codereview.chromium.org/330283004/diff/1/chrome/browser/resources/login/user_pod_row.css File chrome/browser/resources/login/user_pod_row.css (left): https://codereview.chromium.org/330283004/diff/1/chrome/browser/resources/login/user_pod_row.css#oldcode255 ...
6 years, 6 months ago (2014-06-16 18:10:56 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/330283004/diff/80001/chrome/browser/resources/login/user_pod_row.js File chrome/browser/resources/login/user_pod_row.js (right): https://codereview.chromium.org/330283004/diff/80001/chrome/browser/resources/login/user_pod_row.js#newcode1911 chrome/browser/resources/login/user_pod_row.js:1911: // On desktop, we want the rows to ...
6 years, 6 months ago (2014-06-17 09:39:23 UTC) #4
noms (inactive)
https://codereview.chromium.org/330283004/diff/80001/chrome/browser/resources/login/user_pod_row.js File chrome/browser/resources/login/user_pod_row.js (right): https://codereview.chromium.org/330283004/diff/80001/chrome/browser/resources/login/user_pod_row.js#newcode1911 chrome/browser/resources/login/user_pod_row.js:1911: // On desktop, we want the rows to always ...
6 years, 6 months ago (2014-06-17 13:55:44 UTC) #5
noms (inactive)
The CQ bit was unchecked by noms@chromium.org
6 years, 6 months ago (2014-06-17 13:55:56 UTC) #6
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 6 months ago (2014-06-17 13:55:56 UTC) #7
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 6 months ago (2014-06-17 13:55:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/330283004/100001
6 years, 6 months ago (2014-06-17 13:57:10 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 18:39:11 UTC) #10
Message was sent while issue was closed.
Change committed as 277815

Powered by Google App Engine
This is Rietveld 408576698