Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 330253002: WebSocket should stop resuming when suspended. (Closed)

Created:
6 years, 6 months ago by yhirano
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

WebSocket should stop resuming when suspended. WebSocket::resume starts a timer which does the actual resume work when fired. WebSocket::suspend must stop the timer in case it is called while the timer is active. BUG=NONE R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
6 years, 6 months ago (2014-06-13 09:33:34 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-17 04:16:01 UTC) #2
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 6 months ago (2014-06-17 04:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/330253002/1
6 years, 6 months ago (2014-06-17 04:47:00 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 05:57:09 UTC) #5
Message was sent while issue was closed.
Change committed as 176283

Powered by Google App Engine
This is Rietveld 408576698