Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 330233002: Create a new component "autocomplete" (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
Peter Kasting, sky, blundell
CC:
chromium-reviews, James Su, browser-components-watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Create a new component "autocomplete" Move chrome/browser/autocomplete/url_prefix.{cc,h} to components/autocomplete BUG=371538 TEST=git cl try TBR=sky@chromium.org for chrome/browser/DEPS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277616

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rebase, DEPS & OWNERS fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -182 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/url_prefix.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/autocomplete/url_prefix.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/DEPS View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/scored_history_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +1 line, -2 lines 0 comments Download
M components/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + components/autocomplete.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autocomplete/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A + components/autocomplete/url_prefix.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autocomplete/url_prefix.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hashimoto
Please review. sky@: as an owner of chrome/browser/autocomplete (and chrome/browser) blundell@: as an owner of ...
6 years, 6 months ago (2014-06-13 08:15:01 UTC) #1
blundell
LGTM! https://codereview.chromium.org/330233002/diff/20001/chrome/browser/history/DEPS File chrome/browser/history/DEPS (left): https://codereview.chromium.org/330233002/diff/20001/chrome/browser/history/DEPS#oldcode22 chrome/browser/history/DEPS:22: "!chrome/browser/autocomplete/url_prefix.h", Please actually leave this temporary dependency in ...
6 years, 6 months ago (2014-06-16 14:10:52 UTC) #2
sky
sky->pkasting
6 years, 6 months ago (2014-06-16 14:28:57 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/330233002/diff/20001/components/autocomplete/OWNERS File components/autocomplete/OWNERS (right): https://codereview.chromium.org/330233002/diff/20001/components/autocomplete/OWNERS#newcode2 components/autocomplete/OWNERS:2: sky@chromium.org You should remove sky from this list ...
6 years, 6 months ago (2014-06-16 19:49:58 UTC) #4
hashimoto
https://codereview.chromium.org/330233002/diff/20001/chrome/browser/history/DEPS File chrome/browser/history/DEPS (left): https://codereview.chromium.org/330233002/diff/20001/chrome/browser/history/DEPS#oldcode22 chrome/browser/history/DEPS:22: "!chrome/browser/autocomplete/url_prefix.h", On 2014/06/16 14:10:52, blundell wrote: > Please actually ...
6 years, 6 months ago (2014-06-16 20:24:56 UTC) #5
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-16 20:25:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/330233002/60001
6 years, 6 months ago (2014-06-16 20:28:13 UTC) #7
hashimoto
TBRing sky@chromium.org for chrome/browser/DEPS
6 years, 6 months ago (2014-06-16 20:33:01 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 01:54:55 UTC) #9
Message was sent while issue was closed. 
Change committed as 277616

Powered by Google App Engine
This is Rietveld 408576698