Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 330223004: [DevTools] Responsive design UI rework. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Responsive design UI rework. This change moves most of the emulation under |emulateDevice| setting. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -290 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 6 chunks +17 lines, -78 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 6 chunks +52 lines, -138 lines 0 comments Download
M Source/devtools/front_end/overrides.css View 6 chunks +29 lines, -35 lines 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 17 chunks +80 lines, -39 lines 0 comments Download
M Source/devtools/front_end/ui/SettingsUI.js View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-16 15:44:05 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-16 16:09:13 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-16 16:09:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/330223004/1
6 years, 6 months ago (2014-06-16 16:10:53 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 18:19:48 UTC) #5
Message was sent while issue was closed.
Change committed as 176230

Powered by Google App Engine
This is Rietveld 408576698