Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: build/java_apk.gypi

Issue 330203006: Add an empty native library to gyp_managed_install's incomplete apks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/touch.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index 348ce815855af14a7ad1dc54f3e8ecc962a3ebaf..93f3e7c989880fe2e9bba2d47d83efbe436135ef 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -321,6 +321,9 @@
'conditions': [
['gyp_managed_install == 1', {
'variables': {
+ 'placeholder_native_library_path':
+ '<(apk_package_native_libs_dir)/<(android_app_abi)/libfix.crbug.384638.so',
Yaron 2014/06/14 00:39:15 Maybe add a comment that this just needs to be pla
+ 'package_input_paths': [ '<(placeholder_native_library_path)' ],
'libraries_top_dir': '<(intermediate_dir)/lib.stripped',
'libraries_source_dir': '<(libraries_top_dir)/lib/<(android_app_abi)',
'device_library_dir': '<(device_intermediate_dir)/lib.stripped',
@@ -334,6 +337,19 @@
'includes': ['../build/android/push_libraries.gypi'],
},
{
+ 'action_name': 'create placeholder lib',
+ 'inputs': [
+ '<(DEPTH)/build/android/gyp/touch.py',
+ ],
+ 'outputs': [
+ '<(placeholder_native_library_path)',
+ ],
+ 'action' : [
+ 'python', '<(DEPTH)/build/android/gyp/touch.py',
+ '<@(_outputs)',
+ ],
+ },
+ {
'action_name': 'create device library symlinks',
'message': 'Creating links on device for <(_target_name)',
'inputs': [
« no previous file with comments | « build/android/gyp/touch.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698