Issue 330203006: Add an empty native library to gyp_managed_install's incomplete apks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330203006: Add an empty native library to gyp_managed_install's incomplete apks (Closed)

Created:
6 years, 6 months ago by cjhopman

Modified:
6 years, 4 months ago

Reviewers:
Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an empty native library to gyp_managed_install's incomplete apks This is required to install these apks on some devices. BUG=384638 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286028

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	A +	build/android/gyp/touch.py	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	build/java_apk.gypi	View	1 2	2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://codereview.chromium.org/330203006/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/330203006/diff/1/build/java_apk.gypi#newcode325 build/java_apk.gypi:325: '<(apk_package_native_libs_dir)/<(android_app_abi)/libfix.crbug.384638.so', Maybe add a comment that this just ...

6 years, 6 months ago (2014-06-14 00:39:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/330203006/40001

6 years, 4 months ago (2014-07-28 20:36:00 UTC) #4

Message was sent while issue was closed.

Change committed as 286028

Expand Messages | Collapse Messages