Issue 330193006: Adds a layout test that style in sibling shadow shouldn't match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330193006: Adds a layout test that style in sibling shadow shouldn't match. (Closed)

Created:
6 years, 6 months ago by kochi

Modified:
6 years, 6 months ago

Reviewers:
tasak

CC:
blink-reviews, hayato, esprehn

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Adds a layout test that style in sibling shadow shouldn't match. This test is based on sorvell@'s test case reported at http://jsbin.com/ganocegu/4/edit for crbug.com/355674. As the result of moving style in shadow's scope from its host to its root, this issue has been fixed since r176304. This is the test case to catch any regression about shadow's sibling matching. BUG=355674 TEST=this layout test passes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176382

Patch Set 1 #

Patch Set 2 : update #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	A	LayoutTests/fast/dom/shadow/content-pseudo-element-ignore-sibling.html	View		1 chunk	+19 lines, -0 lines	0 comments	Download
	A	LayoutTests/fast/dom/shadow/content-pseudo-element-ignore-sibling-expected.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kochi

Hi Takashi, Could you review this? This is the end of the series of fixing ...

6 years, 6 months ago (2014-06-18 01:11:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/330193006/20001

6 years, 6 months ago (2014-06-18 02:17:12 UTC) #4

Message was sent while issue was closed.

Change committed as 176382

Expand Messages | Collapse Messages