Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: Source/bindings/v8/V8Callback.cpp

Issue 330163004: Fix V8 callback binding for "CallWith=ThisValue" attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add extra layout test cases from https://codereview.chromium.org/330973002. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8Callback.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Callback.cpp
diff --git a/Source/bindings/v8/V8Callback.cpp b/Source/bindings/v8/V8Callback.cpp
index 2857b0477199079d80192db7f47e1eb80227e088..b47b3daf58a1ca923a61d48b8b900c7e8d316a43 100644
--- a/Source/bindings/v8/V8Callback.cpp
+++ b/Source/bindings/v8/V8Callback.cpp
@@ -41,11 +41,11 @@ bool invokeCallback(ScriptState* scriptState, v8::Local<v8::Function> callback,
return invokeCallback(scriptState, callback, scriptState->context()->Global(), argc, argv);
}
-bool invokeCallback(ScriptState* scriptState, v8::Local<v8::Function> callback, v8::Handle<v8::Object> thisObject, int argc, v8::Handle<v8::Value> argv[])
+bool invokeCallback(ScriptState* scriptState, v8::Local<v8::Function> callback, v8::Handle<v8::Value> thisValue, int argc, v8::Handle<v8::Value> argv[])
{
v8::TryCatch exceptionCatcher;
exceptionCatcher.SetVerbose(true);
- ScriptController::callFunction(scriptState->executionContext(), callback, thisObject, argc, argv, scriptState->isolate());
+ ScriptController::callFunction(scriptState->executionContext(), callback, thisValue, argc, argv, scriptState->isolate());
return !exceptionCatcher.HasCaught();
}
« no previous file with comments | « Source/bindings/v8/V8Callback.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698