Source/bindings/templates/callback_interface.cpp - Issue 330163004: Fix V8 callback binding for "CallWith=ThisValue" attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/callback_interface.cpp

Issue 330163004: Fix V8 callback binding for "CallWith=ThisValue" attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra layout test cases from https://codereview.chromium.org/330973002. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/headermap-worker.js ('k') | Source/bindings/tests/results/V8TestCallbackInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/callback_interface.cpp

diff --git a/Source/bindings/templates/callback_interface.cpp b/Source/bindings/templates/callback_interface.cpp

index ade6c6b50c6e9eb03c97081a156ed0c039fa8bd0..5f33caa55ab4a341142f812dfff0a7007281c384 100644

--- a/Source/bindings/templates/callback_interface.cpp

+++ b/Source/bindings/templates/callback_interface.cpp

@@ -45,7 +45,6 @@ namespace WebCore {

CRASH();

{{return_default}};

}

- ASSERT(thisHandle->IsObject());

{% endif %}

{% for argument in method.arguments %}

v8::Handle<v8::Value> {{argument.handle}} = {{argument.cpp_value_to_v8_value}};

@@ -61,7 +60,7 @@ namespace WebCore {

v8::Handle<v8::Value> *argv = 0;

{% endif %}

- {% set this_handle_parameter = 'v8::Handle<v8::Object>::Cast(thisHandle), ' if method.call_with_this_handle else '' %}

+ {% set this_handle_parameter = 'thisHandle, ' if method.call_with_this_handle else '' %}

{% if method.idl_type == 'boolean' %}

return invokeCallback(m_scriptState.get(), m_callback.newLocal(isolate), {{this_handle_parameter}}{{method.arguments | length}}, argv);

{% else %}{# void #}