Source/bindings/v8/V8Callback.h - Issue 330163004: Fix V8 callback binding for "CallWith=ThisValue" attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Callback.h

Issue 330163004: Fix V8 callback binding for "CallWith=ThisValue" attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/callback_interface.cpp ('K') | « Source/bindings/tests/results/V8TestCallbackInterface.cpp ('k') | Source/bindings/v8/V8Callback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8Callback.h

diff --git a/Source/bindings/v8/V8Callback.h b/Source/bindings/v8/V8Callback.h

index 603fc7e84c65d4274f7c0416fb2602c134e7bd41..f6126243f2729247d8bded4b40e717b34a619219 100644

--- a/Source/bindings/v8/V8Callback.h

+++ b/Source/bindings/v8/V8Callback.h

@@ -42,7 +42,7 @@ class ExecutionContext;

// Returns false if the callback threw an exception, true otherwise.

bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, int argc, v8::Handle<v8::Value> argv[]);

-bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v8::Object> thisObject, int argc, v8::Handle<v8::Value> argv[]);

+bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v8::Value> thisValue, int argc, v8::Handle<v8::Value> argv[]);

// FIXME: This file is used only by V8GeolocationCustom.cpp. Remove the custom binding and this file.

enum CallbackAllowedValueFlag {