Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/bindings/v8/V8Callback.h

Issue 330163004: Fix V8 callback binding for "CallWith=ThisValue" attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add extra layout test cases from https://codereview.chromium.org/330973002. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 #include "bindings/v8/V8Binding.h" 35 #include "bindings/v8/V8Binding.h"
36 #include "core/dom/ExceptionCode.h" 36 #include "core/dom/ExceptionCode.h"
37 #include <v8.h> 37 #include <v8.h>
38 38
39 namespace WebCore { 39 namespace WebCore {
40 40
41 class ExecutionContext; 41 class ExecutionContext;
42 42
43 // Returns false if the callback threw an exception, true otherwise. 43 // Returns false if the callback threw an exception, true otherwise.
44 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, int argc, v8 ::Handle<v8::Value> argv[]); 44 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, int argc, v8 ::Handle<v8::Value> argv[]);
45 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v 8::Object> thisObject, int argc, v8::Handle<v8::Value> argv[]); 45 bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v 8::Value> thisValue, int argc, v8::Handle<v8::Value> argv[]);
46 46
47 // FIXME: This file is used only by V8GeolocationCustom.cpp. Remove the custom b inding and this file. 47 // FIXME: This file is used only by V8GeolocationCustom.cpp. Remove the custom b inding and this file.
48 enum CallbackAllowedValueFlag { 48 enum CallbackAllowedValueFlag {
49 CallbackAllowUndefined = 1, 49 CallbackAllowUndefined = 1,
50 CallbackAllowNull = 1 << 1 50 CallbackAllowNull = 1 << 1
51 }; 51 };
52 52
53 typedef unsigned CallbackAllowedValueFlags; 53 typedef unsigned CallbackAllowedValueFlags;
54 54
55 // 'FunctionOnly' is assumed for the created callback. 55 // 'FunctionOnly' is assumed for the created callback.
(...skipping 14 matching lines...) Expand all
70 exceptionState.throwIfNeeded(); 70 exceptionState.throwIfNeeded();
71 return nullptr; 71 return nullptr;
72 } 72 }
73 73
74 return V8CallbackType::create(v8::Handle<v8::Function>::Cast(value), ScriptS tate::current(isolate)); 74 return V8CallbackType::create(v8::Handle<v8::Function>::Cast(value), ScriptS tate::current(isolate));
75 } 75 }
76 76
77 } // namespace WebCore 77 } // namespace WebCore
78 78
79 #endif // V8Callback_h 79 #endif // V8Callback_h
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestCallbackInterface.cpp ('k') | Source/bindings/v8/V8Callback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698