First version of a QUIC SendAlgorithmSimulator which is designed to

First version of a QUIC SendAlgorithmSimulator which is designed to
simulate BBR and TCP flows and changes.

Merge internal change: 69035927

R=rch@chromium.org

[ramant (doing other things), 2014-06-13 03:06:59]

Hi Ian and Ryan,
  Moved SampleRandom class from net/tools/quic/test_tools into
net/quic/test_tools so that SendAlgorithmSimulator class can use it.

  Used size_t instead of int for send_bytes (ok'ed by jri).

thanks
raman

[Ryan Hamilton, 2014-06-13 20:24:03]

This seesm to have some changes that look unrelated to the internal CL. Is that
expected?

[ramant (doing other things), 2014-06-13 23:25:06]

On 2014/06/13 20:24:03, Ryan Hamilton wrote:
> This seesm to have some changes that look unrelated to the internal CL. Is
that
> expected?

send_algorithm_simulator.* files are the same as internal versions (except
indentation). send_algorithm_simulator.cc is using SimpleRandom class. That
class was defined in net/tools/quic. Moved that class from net/tools/quic to
net/quic. Should I move the files in a separate CL and then merge Ian's CL?

thanks
raman

[Ryan Hamilton, 2014-06-13 23:43:15]

lgtm

https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
File net/quic/quic_session_test.cc (right):

https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
net/quic/quic_session_test.cc:851: session_.OnStreamFrames(frames);
I was thinking about this change, too.

[ramant (doing other things), 2014-06-14 00:05:29]

Thanks much Ryan for reviewing all these changes (even when you are not feeling
well).

https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
File net/quic/quic_session_test.cc (right):

https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
net/quic/quic_session_test.cc:851: session_.OnStreamFrames(frames);
On 2014/06/13 23:43:15, Ryan Hamilton wrote:
> I was thinking about this change, too.

I will port the above change back to internal code. The C++ compiler chromium
uses complains about std::vector initialization using {}. Defined the vector and
added the element using push_back (hopefully with c++11 we can undo this
change).

[Jana, 2014-06-14 00:57:27]

Hmm... I don't think the quic_session_test change should be part of this CL.

https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
File net/quic/quic_session_test.cc (right):

https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
net/quic/quic_session_test.cc:851: session_.OnStreamFrames(frames);
I don't think this change was part of the original internal CL. Something in the
merge went wrong, maybe?

On 2014/06/14 00:05:28, ramant wrote:
> On 2014/06/13 23:43:15, Ryan Hamilton wrote:
> > I was thinking about this change, too.
> 
> I will port the above change back to internal code. The C++ compiler chromium
> uses complains about std::vector initialization using {}. Defined the vector
and
> added the element using push_back (hopefully with c++11 we can undo this
> change).

[ramant (doing other things), 2014-06-14 01:04:36]

On 2014/06/14 00:57:27, Jana wrote:
> Hmm... I don't think the quic_session_test change should be part of this CL.
> 
>
https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
> File net/quic/quic_session_test.cc (right):
> 
>
https://codereview.chromium.org/330163003/diff/60001/net/quic/quic_session_te...
> net/quic/quic_session_test.cc:851: session_.OnStreamFrames(frames);
> I don't think this change was part of the original internal CL. Something in
the
> merge went wrong, maybe?
> 
> On 2014/06/14 00:05:28, ramant wrote:
> > On 2014/06/13 23:43:15, Ryan Hamilton wrote:
> > > I was thinking about this change, too.
> > 
> > I will port the above change back to internal code. The C++ compiler
chromium
> > uses complains about std::vector initialization using {}. Defined the vector
> and
> > added the element using push_back (hopefully with c++11 we can undo this
> > change).

Did a rebase with TOT and that change is not part of this CL any more.

Really sorry about that (I had 20 level deep branch and didn't upload after
rebasing on to the master).

[Ryan Hamilton, 2014-06-14 01:50:28]

On 2014/06/14 01:04:36, ramant wrote:
> 
> Really sorry about that (I had 20 level deep branch and didn't upload after
> rebasing on to the master).

I never should have doubted you! Raman, you're amazing.

[ramant (doing other things), 2014-06-14 23:10:59]

On 2014/06/14 01:50:28, Ryan Hamilton wrote:
> On 2014/06/14 01:04:36, ramant wrote:
> > 
> > Really sorry about that (I had 20 level deep branch and didn't upload after
> > rebasing on to the master).
> 
> I never should have doubted you! Raman, you're amazing.

Wow!. Many many thanks Ryan (you are the guru). You have very patiently taught
me git stuff.

[chromium-reviews, 2014-06-15 05:52:42]

Excellent! Glad to hear it was sorted out :-)

On Saturday, 14 June 2014, <rtenneti@chromium.org> wrote:

> On 2014/06/14 01:50:28, Ryan Hamilton wrote:
>
>> On 2014/06/14 01:04:36, ramant wrote:
>> >
>> > Really sorry about that (I had 20 level deep branch and didn't upload
>> after
>> > rebasing on to the master).
>>
>
>  I never should have doubted you! Raman, you're amazing.
>>
>
> Wow!. Many many thanks Ryan (you are the guru). You have very patiently
> taught
> me git stuff.
>
> https://codereview.chromium.org/330163003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.