Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 330143002: Simplify geolocation permission request in the Content API. (Closed)

Created:
6 years, 6 months ago by jam
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, Michael van Ouwerkerk, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, site-isolation-reviews_chromium.org, felt
Project:
chromium
Visibility:
Public.

Description

Simplify geolocation permission request in the Content API. This is the model I used for notifications and will use for other features as they move from RenderView to RenderFrame. BUG=304341 R=avi@chromium.org, mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277038

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix clang #

Patch Set 4 : fix content tests #

Patch Set 5 : fix android #

Patch Set 6 : upload to retry and specify revision #

Patch Set 7 : fix android compile and webview browsertest #

Patch Set 8 : fix layout test #

Total comments: 2

Patch Set 9 : review comment #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -2094 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 2 3 4 3 chunks +0 lines, -5 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 5 6 7 8 1 chunk +19 lines, -0 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge_base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M android_webview/browser/jni_dependency_factory.h View 2 chunks +0 lines, -3 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 1 2 3 4 3 chunks +35 lines, -0 lines 0 comments Download
D android_webview/native/aw_geolocation_permission_context.h View 1 chunk +0 lines, -42 lines 0 comments Download
D android_webview/native/aw_geolocation_permission_context.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M android_webview/native/webview_native.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 3 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 4 chunks +21 lines, -5 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 chunk +0 lines, -323 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_android.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_extensions.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_extensions.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 chunk +0 lines, -697 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context.h View 6 chunks +24 lines, -21 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context.cc View 1 2 3 4 5 6 13 chunks +42 lines, -36 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_android.h View 4 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_android.cc View 7 chunks +18 lines, -19 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_extensions.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_extensions.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_factory.h View 2 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_factory.cc View 6 chunks +18 lines, -20 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 8 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/geolocation/geolocation_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.h View 1 2 3 chunks +21 lines, -3 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.cc View 1 2 3 4 5 6 7 4 chunks +67 lines, -36 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_context.h View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 7 3 chunks +27 lines, -15 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 5 6 7 3 chunks +16 lines, -6 lines 0 comments Download
D content/public/browser/geolocation_permission_context.h View 1 chunk +0 lines, -48 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
mkosiba: android_webview avi: the rest The motivation here is that all these requestpermission calls need ...
6 years, 6 months ago (2014-06-12 21:38:55 UTC) #1
Avi (use Gerrit)
Non-Android stuff LGTM.
6 years, 6 months ago (2014-06-13 00:36:24 UTC) #2
mkosiba (inactive)
Thanks Jam! android_webview LGTM. https://codereview.chromium.org/330143002/diff/140001/android_webview/browser/aw_content_browser_client.cc File android_webview/browser/aw_content_browser_client.cc (right): https://codereview.chromium.org/330143002/diff/140001/android_webview/browser/aw_content_browser_client.cc#newcode403 android_webview/browser/aw_content_browser_client.cc:403: << "permission request."; do we ...
6 years, 6 months ago (2014-06-13 08:17:03 UTC) #3
jam
6 years, 6 months ago (2014-06-13 14:56:08 UTC) #4
https://codereview.chromium.org/330143002/diff/140001/android_webview/browser...
File android_webview/browser/aw_content_browser_client.cc (right):

https://codereview.chromium.org/330143002/diff/140001/android_webview/browser...
android_webview/browser/aw_content_browser_client.cc:403: << "permission
request.";
On 2014/06/13 08:17:03, mkosiba wrote:
> do we need to result_callback.Run(false); in this case?

Done.

Powered by Google App Engine
This is Rietveld 408576698