Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 330133004: X87: Fixed flooring division by a power of 2, once again... (Closed)

Created:
6 years, 6 months ago by chunyang.dai
Modified:
6 years, 6 months ago
Reviewers:
Weiliang, Sven Panne
CC:
v8-dev, danno
Visibility:
Public.

Description

X87: Fixed flooring division by a power of 2, once again... port r21769 original message: Avoid right shifts by zero bits: On ARM it actually means shifting by 32 bits (correctness issue) and on other platforms they are useless (performance issue). This is fix for the fix in r20544. BUG=v8:3259 LOG=y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
chunyang.dai
wl. please review and commit this patch. thanks.
6 years, 6 months ago (2014-06-13 03:25:05 UTC) #1
Weiliang
lgtm
6 years, 6 months ago (2014-06-13 03:44:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/chunyang.dai@intel.com/330133004/1
6 years, 6 months ago (2014-06-13 03:45:33 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 03:45:34 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-13 03:45:35 UTC) #5
Sven Panne
FYI: We don't really have a commit queue for v8 yet (only try bots), so ...
6 years, 6 months ago (2014-06-13 06:42:16 UTC) #6
Weiliang
6 years, 6 months ago (2014-06-13 07:05:58 UTC) #7
Committed as r21829

Powered by Google App Engine
This is Rietveld 408576698