Fixing flaky overscroll and touch exploration mode browser tests.

content/public/test/browser_test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/browser_test_utils.h"
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
 #include "base/process/kill.h"
@@ skipping 16 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/test/test_utils.h"
 #include "grit/webui_resources.h"
 #include "net/base/filename_util.h"
 #include "net/cookies/cookie_store.h"
 #include "net/test/python_utils.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/aura/window.h"

[jam, 2014/06/19 16:25:31]

this isn't going to compile on platforms where we don't use aura

seems like you want to wrap the new method with an USE_AURA ifdef since it's
only used in aura tests anyways?

(nit: in the future, sending tryjobs before review would be helpful in catching
these things before a reviewer looks at it)

[mfomitchev, 2014/06/19 20:04:56]

Done. Good point.

+#include "ui/aura/window_event_dispatcher.h"
+#include "ui/aura/window_tree_host.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "ui/compositor/test/draw_waiter_for_test.h"
 #include "ui/events/gestures/gesture_configuration.h"
 #include "ui/events/keycodes/dom4/keycode_converter.h"
 
 namespace content {
 namespace {
 
 class DOMOperationObserver : public NotificationObserver,
                              public WebContentsObserver {
  public:
   explicit DOMOperationObserver(RenderViewHost* rvh)
@@ skipping 148 matching lines @@
   GURL url = net::FilePathToFileURL(path);
   if (!query_string.empty()) {
     GURL::Replacements replacements;
     replacements.SetQueryStr(query_string);
     return url.ReplaceComponents(replacements);
   }
   return url;
 }
 
 void WaitForLoadStop(WebContents* web_contents) {
-    WindowedNotificationObserver load_stop_observer(
-    NOTIFICATION_LOAD_STOP,
-    Source<NavigationController>(&web_contents->GetController()));
   // In many cases, the load may have finished before we get here.  Only wait if
   // the tab still has a pending navigation.
-  if (!web_contents->IsLoading())
-    return;
-  load_stop_observer.Wait();
+  if (web_contents->IsLoading()) {
+    WindowedNotificationObserver load_stop_observer(
+        NOTIFICATION_LOAD_STOP,
+        Source<NavigationController>(&web_contents->GetController()));
+    load_stop_observer.Wait();
+  }
 }
 
 void CrashTab(WebContents* web_contents) {
   RenderProcessHost* rph = web_contents->GetRenderProcessHost();
   RenderProcessHostWatcher watcher(
       rph, RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
   base::KillProcess(rph->GetHandle(), 0, false);
   watcher.Wait();
 }
 
+bool IsResizeComplete(aura::WindowEventDispatcher* dispatcher,
+                      RenderWidgetHostImpl* widget_host) {
+  return !dispatcher->HoldingPointerMovesForTesting() &&
+      !widget_host->IsResizeAckPendingForTesting();
+}
+
+void WaitForResizeComplete(WebContents* web_contents) {
+  aura::Window* content = web_contents->GetContentNativeView();
+  if (content) {
+    aura::WindowTreeHost* window_host = content->GetHost();
+    aura::WindowEventDispatcher* dispatcher = window_host->dispatcher();
+    RenderWidgetHostImpl* widget_host =
+        RenderWidgetHostImpl::From(web_contents->GetRenderViewHost());
+    if (!IsResizeComplete(dispatcher, widget_host)) {
+      WindowedNotificationObserver resize_observer(
+          NOTIFICATION_RENDER_WIDGET_HOST_DID_UPDATE_BACKING_STORE,
+          base::Bind(IsResizeComplete, dispatcher, widget_host));
+      resize_observer.Wait();
+    }
+  }
+}
+
 void SimulateMouseClick(WebContents* web_contents,
                         int modifiers,
                         blink::WebMouseEvent::Button button) {
   int x = web_contents->GetContainerBounds().width() / 2;
   int y = web_contents->GetContainerBounds().height() / 2;
   SimulateMouseClickAt(web_contents, modifiers, button, gfx::Point(x, y));
 }
 
 void SimulateMouseClickAt(WebContents* web_contents,
                           int modifiers,
@@ skipping 459 matching lines @@
   }
   // The queue should not be empty, unless we were quit because of a timeout.
   if (message_queue_.empty())
     return false;
   *message = message_queue_.front();
   message_queue_.pop();
   return true;
 }
 
 }  // namespace content