Fixing flaky overscroll and touch exploration mode browser tests.

content/public/test/browser_test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/browser_test_utils.h"
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
 #include "base/process/kill.h"
@@ skipping 16 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/test/test_utils.h"
 #include "grit/webui_resources.h"
 #include "net/base/filename_util.h"
 #include "net/cookies/cookie_store.h"
 #include "net/test/python_utils.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/aura/window.h"
+#include "ui/aura/window_event_dispatcher.h"
+#include "ui/aura/window_tree_host.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "ui/compositor/test/draw_waiter_for_test.h"
 #include "ui/events/gestures/gesture_configuration.h"
 #include "ui/events/keycodes/dom4/keycode_converter.h"
 
 namespace content {
 namespace {
 
 class DOMOperationObserver : public NotificationObserver,
                              public WebContentsObserver {
  public:
   explicit DOMOperationObserver(RenderViewHost* rvh)
@@ skipping 153 matching lines @@
   }
   return url;
 }
 
 void WaitForLoadStop(WebContents* web_contents) {
     WindowedNotificationObserver load_stop_observer(
     NOTIFICATION_LOAD_STOP,
     Source<NavigationController>(&web_contents->GetController()));
   // In many cases, the load may have finished before we get here.  Only wait if
   // the tab still has a pending navigation.
-  if (!web_contents->IsLoading())
-    return;
-  load_stop_observer.Wait();
+  if (web_contents->IsLoading())
+    load_stop_observer.Wait();
+  WaitForResizeComplete(web_contents);
 }
 
 void CrashTab(WebContents* web_contents) {
   RenderProcessHost* rph = web_contents->GetRenderProcessHost();
   RenderProcessHostWatcher watcher(
       rph, RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
   base::KillProcess(rph->GetHandle(), 0, false);
   watcher.Wait();
 }
 
+void WaitForResizeComplete(WebContents* web_contents) {
+  LOG(ERROR) << "WaitForResizeToComplete";
+  LOG(ERROR) << "web_contents=" << web_contents;
+  aura::Window* content = web_contents->GetContentNativeView();
+  LOG(ERROR) << 1;
+  LOG(ERROR) << "content=" << content;
+  if (content) {
+    aura::WindowTreeHost* host = content->GetHost();
+    LOG(ERROR) << 2;
+    aura::WindowEventDispatcher* dispatcher = host->dispatcher();
+    LOG(ERROR) << 3;
+    while (dispatcher->HoldingPointerMovesForTest()) {
+      LOG(ERROR) << "HoldingPointerMovesForTest";
+      ui::DrawWaiterForTest::WaitForCommit(host->compositor());
+      LOG(ERROR) << "WaitForCommit done";
+      LOG(ERROR) << "dispatcher->HoldingPointerMovesForTest()="
+          << dispatcher->HoldingPointerMovesForTest();
+    }
+  }
+}
+

[sadrul, 2014/06/12 23:25:51]

Could this work with RenderWidgetHostImpl::resize_ack_pending_ instead of with
aura::WindowEventDispatcher::move_hold_count_? That way, it would be applicable
on all platforms.

I am not sure that DrawWaiterForTest::WaitForCommit() is the right thing to do
while waiting for the resize to end. Ideally, this would work like
WaitForLoadStop(), where it spins up a nested message-loop and terminates it
when an event happens (e.g. checking resize_ack_pending_ on
NOTIFICATION_RENDER_WIDGET_HOST_DID_UPDATE_BACKING_STORE might work for this
case, although it doesn't feel that clean).

[mfomitchev, 2014/06/13 15:20:57]

Done.

 void SimulateMouseClick(WebContents* web_contents,
                         int modifiers,
                         blink::WebMouseEvent::Button button) {
   int x = web_contents->GetContainerBounds().width() / 2;
   int y = web_contents->GetContainerBounds().height() / 2;
   SimulateMouseClickAt(web_contents, modifiers, button, gfx::Point(x, y));
 }
 
 void SimulateMouseClickAt(WebContents* web_contents,
                           int modifiers,
@@ skipping 459 matching lines @@
   }
   // The queue should not be empty, unless we were quit because of a timeout.
   if (message_queue_.empty())
     return false;
   *message = message_queue_.front();
   message_queue_.pop();
   return true;
 }
 
 }  // namespace content