[Isolates] Add heap pointer to all maps and use map->heap() more.

[Isolates] Add heap pointer to all maps and use map->heap() more.

Other changes:
1. Spaces (NewSpace, PagedSpace etc) get heap_ member.
2. MarkCompactCollector already has heap_ - use it more.
3. Made Heap::ScavengeObject() a static to avoid pulling heap pointer until the slow path is taken.
4. Changed HEAP_PROFILE(Call) macro to be HEAP_PROFILE(heap, call) to avoid 2 Isolate::Current() that it had.
5. Heap::IterateDirtyRegions now passes heap pointer to a callback.
6. ScavengingVisitor::EvacuateObject and others use map->heap() to retrieve heap during GC.

Committed: http://code.google.com/p/v8/source/detail?r=5443

[Dmitry Titov, 2010-09-10 02:27:45]

Ready for a look.

[Vitaly Repeshko, 2010-09-10 12:35:25]

LGTM!

http://codereview.chromium.org/3301008/diff/5002/12003
File src/heap-profiler.h (right):

http://codereview.chromium.org/3301008/diff/5002/12003#newcode45
src/heap-profiler.h:45: if (profiler && profiler->is_profiling()) {             
                \
nit: Use explicit != NULL comparison.

http://codereview.chromium.org/3301008/diff/5002/12004
File src/heap.cc (right):

http://codereview.chromium.org/3301008/diff/5002/12004#newcode1181
src/heap.cc:1181: if (map->heap()->ShouldBePromoted(object->address(),
object_size)) {
We clearly need "heap" as a local variable here.

http://codereview.chromium.org/3301008/diff/5002/12004#newcode1209
src/heap.cc:1209: *slot = MigrateObject(map->heap(), object,
HeapObject::cast(result), object_size);
nit: Long line.

http://codereview.chromium.org/3301008/diff/5002/12004#newcode3674
src/heap.cc:3674: if (Heap::IteratePointersInDirtyRegion(HEAP,
Heap lookup can be moved out of the while loop.

http://codereview.chromium.org/3301008/diff/5002/12006
File src/mark-compact.cc (right):

http://codereview.chromium.org/3301008/diff/5002/12006#newcode2489
src/mark-compact.cc:2489: int
MarkCompactCollector::RelocateOldNonCodeObject(HeapObject* obj,
It'd be really nice to make MarkCompactCollector::Relocate* non-static (then we
could use the heap_ field). These methods are called by non-static
IterateLiveObjectsInRange. Should be easy to pass "this" pointer there. Feel
free to do this in a follow up change.

[Dmitry Titov, 2010-09-10 18:53:06]

Thanks!

Fixed all except making MarkCompactCollector::Relocate* non-static - will post
another patch for that.