Source/build/scripts/templates/MakeNames.h.tmpl - Issue 330093002: Add support in generate scripts to handle Conditional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/MakeNames.h.tmpl

Issue 330093002: Add support in generate scripts to handle Conditional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Also add support for make_names.py script to handle Conditional Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/build/scripts/templates/ElementFactory.cpp.tmpl ('K') | « Source/build/scripts/templates/MakeNames.cpp.tmpl ('k') | Source/core/svg/SVGTagNames.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/build/scripts/templates/MakeNames.h.tmpl

diff --git a/Source/build/scripts/templates/MakeNames.h.tmpl b/Source/build/scripts/templates/MakeNames.h.tmpl

index 704b8e137aa199c1ebaab40e03da8f668d9d5dc7..e6d418cf0a9bb8659706c2ee8f13409302c33329 100644

--- a/Source/build/scripts/templates/MakeNames.h.tmpl

+++ b/Source/build/scripts/templates/MakeNames.h.tmpl

@@ -19,11 +19,13 @@ namespace {{namespace}}Names {

#ifndef {{namespace|to_macro_style}}_NAMES_HIDE_GLOBALS

{% for entry in entries|sort %}

+{% filter enable_conditional(entry.Conditional) %}

{% if export %}

{{export}} extern const WTF::AtomicString& {{entry|symbol}};

{% else %}

extern const WTF::AtomicString {{entry|symbol}};

{% endif %}

+{% endfilter %}

{% endfor %}

#endif // {{namespace|to_macro_style}}_NAMES_HIDE_GLOBALS

« Source/build/scripts/templates/ElementFactory.cpp.tmpl ('K') | « Source/build/scripts/templates/MakeNames.cpp.tmpl ('k') | Source/core/svg/SVGTagNames.in » ('j') | no next file with comments »