Source/build/scripts/make_element_type_helpers.py - Issue 330093002: Add support in generate scripts to handle Conditional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/make_element_type_helpers.py

Issue 330093002: Add support in generate scripts to handle Conditional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Also add support for make_names.py script to handle Conditional Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/build/scripts/make_element_factory.py ('K') | « Source/build/scripts/make_element_factory.py ('k') | Source/build/scripts/make_names.py » ('j') | Source/build/scripts/make_names.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/build/scripts/make_element_type_helpers.py

diff --git a/Source/build/scripts/make_element_type_helpers.py b/Source/build/scripts/make_element_type_helpers.py

index d92ade5d6e5c8851e81670e8fedf0e28b0977e0e..7ecd36593f5325f8ef799a61768c4928ce68d30a 100755

--- a/Source/build/scripts/make_element_type_helpers.py

+++ b/Source/build/scripts/make_element_type_helpers.py

@@ -33,6 +33,7 @@ class MakeElementTypeHelpersWriter(in_generator.Writer):

'interfaceName': None,

'noConstructor': None,

'runtimeEnabled': None,

+ 'Conditional': None,

Nils Barth (inactive) 2014/06/16 06:27:52 alpha (could you alphabetize the earlier interface

}

default_parameters = {

'attrsNullNamespace': None,

@@ -45,6 +46,7 @@ class MakeElementTypeHelpersWriter(in_generator.Writer):

filters = {

'hash': hasher.hash,

'symbol': _symbol,

+ 'enable_conditional': name_utilities.enable_conditional_if_endif,

Nils Barth (inactive) 2014/06/16 06:27:52 alpha

}

def __init__(self, in_file_path):