Issue 330063005: Simplify use of TextDirection enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330063005: Simplify use of TextDirection enum. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, esprehn, eae

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Simplify use of TextDirection enum. There is no need to do "(m_direction == LTR) ? LTR : RTL". While here, remove extra parameters from applyFontTransforms. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176522

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	Source/platform/fonts/WidthIterator.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	Source/platform/fonts/mac/ComplexTextController.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

jbroman

Trivial. Was passing by and noticed the odd "ltr() ? LTR : RTL" construct.

6 years, 6 months ago (2014-06-19 15:17:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/330063005/1

6 years, 6 months ago (2014-06-19 16:15:10 UTC) #4

Message was sent while issue was closed.

Change committed as 176522