Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 330053004: Rename some appcache types in preparation for moving to content namespace (Closed)

Created:
6 years, 6 months ago by pilgrim_google
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename some appcache types in preparation for moving to content namespace BUG=338338 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276872

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -180 lines) Patch
M content/browser/appcache/appcache_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_frontend_proxy.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_frontend_proxy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_group_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/appcache/appcache_host_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/appcache/appcache_unittest.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 9 chunks +11 lines, -10 lines 0 comments Download
M content/browser/appcache/mock_appcache_storage.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/appcache/appcache_backend_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/appcache/appcache_backend_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/appcache/appcache_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/appcache/appcache_dispatcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/appcache/appcache_frontend_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/appcache/appcache_frontend_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/appcache/web_application_cache_host_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/child/appcache/web_application_cache_host_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/common/appcache_messages.h View 5 chunks +9 lines, -8 lines 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_database.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_group.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/appcache/appcache_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_host.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M webkit/browser/appcache/appcache_update_job.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/appcache/appcache_update_job.cc View 24 chunks +38 lines, -34 lines 0 comments Download
M webkit/common/appcache/appcache_interfaces.h View 8 chunks +22 lines, -21 lines 1 comment Download
M webkit/common/appcache/appcache_interfaces.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pilgrim_google
6 years, 6 months ago (2014-06-12 19:09:12 UTC) #1
jam
https://codereview.chromium.org/330053004/diff/1/webkit/common/appcache/appcache_interfaces.h File webkit/common/appcache/appcache_interfaces.h (right): https://codereview.chromium.org/330053004/diff/1/webkit/common/appcache/appcache_interfaces.h#newcode32 webkit/common/appcache/appcache_interfaces.h:32: UNCACHED, ideally all the values would be renamed as ...
6 years, 6 months ago (2014-06-12 19:46:37 UTC) #2
pilgrim_google
On 2014/06/12 19:46:37, jam wrote: > https://codereview.chromium.org/330053004/diff/1/webkit/common/appcache/appcache_interfaces.h > File webkit/common/appcache/appcache_interfaces.h (right): > > https://codereview.chromium.org/330053004/diff/1/webkit/common/appcache/appcache_interfaces.h#newcode32 > ...
6 years, 6 months ago (2014-06-12 20:01:34 UTC) #3
jam
On 2014/06/12 20:01:34, pilgrim_google wrote: > On 2014/06/12 19:46:37, jam wrote: > > > https://codereview.chromium.org/330053004/diff/1/webkit/common/appcache/appcache_interfaces.h ...
6 years, 6 months ago (2014-06-12 20:18:07 UTC) #4
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 6 months ago (2014-06-12 20:31:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/330053004/1
6 years, 6 months ago (2014-06-12 20:35:51 UTC) #6
michaeln
lgtm2
6 years, 6 months ago (2014-06-12 20:41:43 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:52:43 UTC) #8
Message was sent while issue was closed. 
Change committed as 276872

Powered by Google App Engine
This is Rietveld 408576698