Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(198)

Issue 330053003: First crack at adding a GYP_GENERATOR for determining various things (Closed)

Created:
5 years, 5 months ago by sky
Modified:
5 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

First crack at adding a GYP_GENERATOR for determining various things This version reads a file to get a list of input files, then outputs if any of the input files are contained as sources (or inputs to actions/rules) in any targets. R=mark@chromium.org Patch by Scott Violet <sky@chromium.org>; Committed: https://code.google.com/p/gyp/source/detail?r=1936

Patch Set 1 #

Patch Set 2 : copyrights #

Total comments: 9

Patch Set 3 : address review comments #

Total comments: 1

Patch Set 4 : handle // better #

Patch Set 5 : sim 90 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -0 lines) Patch
A pylib/gyp/generator/analyzer.py View 1 2 3 1 chunk +192 lines, -0 lines 0 comments Download
A test/analyzer/gyptest-analyzer.py View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A test/analyzer/subdir/subdir.gyp View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A test/analyzer/test.gyp View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
https://codereview.chromium.org/330053003/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/330053003/diff/20001/pylib/gyp/generator/analyzer.py#newcode43 pylib/gyp/generator/analyzer.py:43: path = path.replace('\\', '/') This feels a bit run, ...
5 years, 5 months ago (2014-06-12 16:41:56 UTC) #1
Mark Mentovai
This seems reasonable. https://codereview.chromium.org/330053003/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/330053003/diff/20001/pylib/gyp/generator/analyzer.py#newcode49 pylib/gyp/generator/analyzer.py:49: """Extracts the path components of the ...
5 years, 5 months ago (2014-06-12 17:40:06 UTC) #2
sky
https://codereview.chromium.org/330053003/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/330053003/diff/20001/pylib/gyp/generator/analyzer.py#newcode49 pylib/gyp/generator/analyzer.py:49: """Extracts the path components of the specified gyp target ...
5 years, 5 months ago (2014-06-12 18:30:54 UTC) #3
Mark Mentovai
https://codereview.chromium.org/330053003/diff/30001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/330053003/diff/30001/pylib/gyp/generator/analyzer.py#newcode70 pylib/gyp/generator/analyzer.py:70: source = source.replace('//', '/') Technically this is only correct ...
5 years, 5 months ago (2014-06-12 18:36:32 UTC) #4
sky
How about this?
5 years, 5 months ago (2014-06-12 19:30:43 UTC) #5
Mark Mentovai
LGTM
5 years, 5 months ago (2014-06-12 20:23:39 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
5 years, 5 months ago (2014-06-12 20:24:43 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 5 months ago (2014-06-12 20:28:57 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 5 months ago (2014-06-12 20:28:58 UTC) #9
Mark Mentovai
Please have a look at the test failures.
5 years, 5 months ago (2014-06-12 21:11:29 UTC) #10
Mark Mentovai
5 years, 5 months ago (2014-06-12 22:52:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 manually as r1936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698